mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 20:09:18 +01:00
Code Issues Projects Releases Wiki Activity

nit: better error messages on dualopend's check_balances failures

Browse source 
Make it easier to figure out what the inputs were to check_balances
on two failure cases
This commit is contained in:
niftynei 2021-07-06 12:19:34 -05:00 • committed by neil saitug
parent 70bf57d54b
commit 68e5c8ca93
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
openingd/dualopend.c
View file

@ -790,8 +790,19 @@ static char *check_balances(const tal_t *ctx,
* - the peer's total input satoshis is less than their outputs
*/
/* We check both, why not? */
if (!amount_sat_greater_eq(initiator_inputs, initiator_outs))
return "initiator inputs less than outputs";
if (!amount_sat_greater_eq(initiator_inputs, initiator_outs)) {
return tal_fmt(tmpctx,
"initiator inputs less than outputs (%s < %s)"
" (lease fee %s)",
type_to_string(tmpctx, struct amount_sat,
&initiator_inputs),
type_to_string(tmpctx, struct amount_sat,
&initiator_outs),
type_to_string(tmpctx, struct amount_sat,
&lease_fee));
}
/* BOLT-f53ca2301232db780843e894f55d95d512f297f9 #2:
* The receiving node: ...
@ -804,7 +815,10 @@ static char *check_balances(const tal_t *ctx,
*/
if (!amount_sat_sub(&accepter_diff, accepter_inputs,
accepter_outs)) {
return "accepter inputs less than outputs";
return tal_fmt(tmpctx, "accepter inputs %s less than outputs %s (lease fee %s)",
type_to_string(tmpctx, struct amount_sat, &accepter_inputs),
type_to_string(tmpctx, struct amount_sat, &accepter_outs),
type_to_string(tmpctx, struct amount_sat, &lease_fee));
}
if (!amount_sat_sub(&initiator_diff, initiator_inputs,