mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-18 05:12:45 +01:00
Code Issues Projects Releases Wiki Activity

json-rpc: Add description to listpayments and similar

Browse Source
This commit is contained in:
Christian Decker 2018-07-23 15:32:47 +02:00 committed by Rusty Russell
parent 6bbe5b60f6
commit 687f171e17
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lightningd/json.c
View File

@ -66,6 +66,8 @@ json_add_payment_fields(struct json_result *response,
json_add_hex(response, "payment_preimage",
t->payment_preimage,
sizeof(*t->payment_preimage));
if (t->description)
json_add_string(response, "description", t->description);
}
void json_add_pubkey(struct json_result *response,

10
tests/test_lightningd.py
View File

@ -1236,20 +1236,22 @@ class LightningDTests(BaseLightningDTests):
# Wait for route propagation.
self.wait_for_routes(l1, [chanid])
inv1 = l2.rpc.invoice(123000, 'test_pay', '1000')['bolt11']
l1.rpc.pay(inv1, description='1000')
inv1 = l2.rpc.invoice(123000, 'test_pay', 'desc')['bolt11']
l1.rpc.pay(inv1, description='desc')
payment1 = l1.rpc.listpayments(inv1)['payments']
assert only_one(payment1)['msatoshi'] == 123000
assert payment1[0]['description'] == 'desc'
inv2 = l2.rpc.invoice(321000, 'test_pay2', 'description')['bolt11']
l1.rpc.pay(inv2, riskfactor=5.0)
payment2 = l1.rpc.listpayments(inv2)['payments']
assert only_one(payment2)['msatoshi'] == 321000
anyinv = l2.rpc.invoice('any', 'any_pay', 'description')['bolt11']
l1.rpc.pay(anyinv, description='1000', msatoshi='500')
anyinv = l2.rpc.invoice('any', 'any_pay', 'desc')['bolt11']
l1.rpc.pay(anyinv, description='desc', msatoshi='500')
payment3 = l1.rpc.listpayments(anyinv)['payments']
assert only_one(payment3)['msatoshi'] == 500
assert payment3[0]['description'] == 'desc'
# Should see 3 completed transactions
assert len(l1.rpc.listpayments()['payments']) == 3