From 632b42da40c5ff57391cb892192dd47f297f5c7c Mon Sep 17 00:00:00 2001 From: niftynei Date: Mon, 18 May 2020 20:50:56 -0500 Subject: [PATCH] hsmd: fix missing return bug One must `return` the bad_req, otherwise you continue onward, usually with bad or unexpected results. introduced in 6b6b7eac61491c8a7ed4c6e939570221f1286f7e --- hsmd/hsmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hsmd/hsmd.c b/hsmd/hsmd.c index 9f9631023..e5cb8e67b 100644 --- a/hsmd/hsmd.c +++ b/hsmd/hsmd.c @@ -1007,7 +1007,7 @@ static struct io_plan *handle_sign_remote_commitment_tx(struct io_conn *conn, &output_witscripts, &remote_per_commit, &option_static_remotekey)) - bad_req(conn, c, msg_in); + return bad_req(conn, c, msg_in); tx->chainparams = c->chainparams; /* Basic sanity checks. */