mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-15 11:59:16 +01:00
Code Issues Projects Releases Wiki Activity

reckless: avoid superfluous config rewrites

Browse source
This commit is contained in:
Alex Myers 2022-12-08 13:10:34 -06:00 • committed by ShahanaFarooqui
parent b59b6b9cec
commit 6163138420
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tools/reckless
View file

@ -154,13 +154,17 @@ class Config():
parent_path)
raise FileNotFoundError('invalid parent directory')
def editConfigFile(self, addline: str, removeline: str):
def editConfigFile(self, addline: Union[str, None],
removeline: Union[str, None]):
"""Idempotent function to add and/or remove a single line each."""
remove_these_lines = []
with open(self.conf_fp, 'r') as reckless_conf:
original = reckless_conf.readlines()
empty_lines = []
write_required = False
for n, l in enumerate(original):
if l.strip() == removeline:
if removeline and l.strip() == removeline.strip():
write_required = True
remove_these_lines.append(n)
continue
if l.strip() == '':
@ -169,6 +173,13 @@ class Config():
# The white space is getting excessive.
remove_these_lines.append(n)
continue
if not addline:
return
# No write necessary if addline is already in config.
if not write_required:
for line in original:
if line.strip() == addline.strip():
return
with open(self.conf_fp, 'w') as conf_write:
# no need to write if passed 'None'
line_exists = not bool(addline)