mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-17 19:03:42 +01:00
Code Issues Projects Releases Wiki Activity

wallet: Make wallet_payment_store idempotent.

Browse Source
This commit is contained in:
ZmnSCPxj 2018-03-09 02:17:51 +00:00 committed by Rusty Russell
parent 8fd71ad654
commit 60f5abdc9b
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
wallet/wallet.c
View File

@ -1516,7 +1516,23 @@ void wallet_payment_store(struct wallet *wallet,
struct wallet_payment *payment; struct wallet_payment *payment;
payment = find_unstored_payment(wallet, payment_hash); payment = find_unstored_payment(wallet, payment_hash);
assert(payment); if (!payment) {
/* Already stored on-disk */
#if DEVELOPER
/* Double-check that it is indeed stored to disk
* (catch bug, where we call this on a payment_hash
* we never paid to) */
int res;
stmt = db_prepare(wallet->db,
"SELECT status FROM payments"
" WHERE payment_hash=?;");
sqlite3_bind_sha256(stmt, 1, payment_hash);
res = sqlite3_step(stmt);
assert(res == SQLITE_ROW);
sqlite3_finalize(stmt);
#endif
return;
}
/* Don't attempt to add the same payment twice */ /* Don't attempt to add the same payment twice */
assert(!payment->id); assert(!payment->id);