mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-01 17:47:30 +01:00
Code Issues Projects Releases Wiki Activity

openchannel2/rbf hooks: reject if response malformed

Browse source 
You gotta send over an amount if you send a psbt!
This commit is contained in:
niftynei 2021-04-21 15:46:32 -05:00 • committed by Rusty Russell
parent 9ba2f614bb
commit 5a04dc185c
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lightningd/dual_open_control.c
View file

@ -622,6 +622,10 @@ rbf_channel_hook_deserialize(struct rbf_channel_payload *payload,
"our_funding_msat", &payload->our_funding))
fatal("Plugin failed to supply our_funding_msat field");
if (payload->psbt
&& amount_sat_eq(payload->our_funding, AMOUNT_SAT(0)))
fatal("Plugin failed to supply our_funding_msat field");
if (!payload->psbt &&
!amount_sat_eq(payload->our_funding, AMOUNT_SAT(0))) {
@ -782,8 +786,12 @@ openchannel2_hook_deserialize(struct openchannel2_payload *payload,
&payload->accepter_funding))
fatal("Plugin failed to supply our_funding_msat field");
if (!payload->psbt &&
!amount_sat_eq(payload->accepter_funding, AMOUNT_SAT(0))) {
if (payload->psbt
&& amount_sat_eq(payload->accepter_funding, AMOUNT_SAT(0)))
fatal("Plugin failed to supply our_funding_msat field");
if (!payload->psbt
&& !amount_sat_eq(payload->accepter_funding, AMOUNT_SAT(0))) {
/* Gotta give a PSBT if you set the accepter_funding amount */
/* Let dualopend know we've failed */
payload->err_msg = "Client error. Unable to continue";