From 59fa47bf64e568313eb8f9655449c5b0eaec55ab Mon Sep 17 00:00:00 2001 From: Christian Decker Date: Sat, 16 Feb 2019 10:12:18 +0100 Subject: [PATCH] pytest: Mark the worst gossip offenders as developer-only tests Signed-off-by: Christian Decker --- tests/test_connection.py | 2 ++ tests/test_gossip.py | 1 + tests/test_invoices.py | 1 + tests/test_pay.py | 2 ++ 4 files changed, 6 insertions(+) diff --git a/tests/test_connection.py b/tests/test_connection.py index 13fca60df..d188d806b 100644 --- a/tests/test_connection.py +++ b/tests/test_connection.py @@ -791,6 +791,7 @@ def test_channel_persistence(node_factory, bitcoind, executor): l1.daemon.wait_for_log(' to ONCHAIN') +@unittest.skipIf(not DEVELOPER, "gossip without DEVELOPER=1 is slow") def test_private_channel(node_factory): l1, l2 = node_factory.line_graph(2, announce_channels=False, wait_for_announce=False) l3, l4 = node_factory.line_graph(2, announce_channels=True, wait_for_announce=True) @@ -1418,6 +1419,7 @@ def test_fulfill_incoming_first(node_factory, bitcoind): l3.daemon.wait_for_log('onchaind complete, forgetting peer') +@unittest.skipIf(not DEVELOPER, "gossip without DEVELOPER=1 is slow") def test_restart_many_payments(node_factory): l1 = node_factory.get_node(may_reconnect=True) diff --git a/tests/test_gossip.py b/tests/test_gossip.py index 0b6000278..cd123ab3d 100644 --- a/tests/test_gossip.py +++ b/tests/test_gossip.py @@ -984,6 +984,7 @@ def test_gossip_notices_close(node_factory, bitcoind): assert(l1.rpc.listnodes()['nodes'] == []) +@unittest.skipIf(not DEVELOPER, "gossip propagation is slow without DEVELOPER=1") def test_getroute_exclude(node_factory, bitcoind): """Test getroute's exclude argument""" l1, l2, l3, l4 = node_factory.line_graph(4, wait_for_announce=True) diff --git a/tests/test_invoices.py b/tests/test_invoices.py index 7d79b480f..3b70ce4f4 100644 --- a/tests/test_invoices.py +++ b/tests/test_invoices.py @@ -172,6 +172,7 @@ def test_invoice_routeboost(node_factory, bitcoind): assert 'warning_offline' not in inv +@unittest.skipIf(not DEVELOPER, "gossip without DEVELOPER=1 is slow") def test_invoice_routeboost_private(node_factory, bitcoind): """Test routeboost 'r' hint in bolt11 invoice for private channels """ diff --git a/tests/test_pay.py b/tests/test_pay.py index 2394a9806..caba5cce2 100644 --- a/tests/test_pay.py +++ b/tests/test_pay.py @@ -1167,6 +1167,7 @@ def test_pay_variants(node_factory): l1.rpc.pay(b11) +@unittest.skipIf(not DEVELOPER, "gossip without DEVELOPER=1 is slow") def test_pay_retry(node_factory, bitcoind): """Make sure pay command retries properly. """ def exhaust_channel(funder, fundee, scid, already_spent=0): @@ -1341,6 +1342,7 @@ def test_pay_routeboost(node_factory, bitcoind): assert [h['channel'] for h in attempts[2]['routehint']] == [r['short_channel_id'] for r in routel3l5] +@unittest.skipIf(not DEVELOPER, "gossip without DEVELOPER=1 is slow") def test_pay_direct(node_factory, bitcoind): """Check that we prefer the direct route. """