mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-02-22 14:42:40 +01:00
Code Issues Projects Releases Wiki Activity

pyln-client: allow dynamic=True add_option to actually allow updates.

Browse source 
We didn't actually *change* the value you'd see, when we got a setconfig call!

Changelog-Added: pyln-client: implement setconfig hook for plugins so you can see changes in `dynamic` options.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2024-05-04 01:28:40 +09:30
parent ead211e5e4
commit 572ccac0e5
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
contrib/pyln-client/pyln/client/plugin.py
View file

@ -974,11 +974,10 @@ class Plugin(object):
return self._exec_func(self.child_init, request)
return None
def _set_config(self, **_) -> None:
def _set_config(self, config: str, val: Optional[Any]) -> None:
"""Called when the value of a dynamic option is changed
For now we don't do anything.
"""
pass
self.options[config]['value'] = val
class PluginStream(object):

6
tests/plugins/dynamic_option.py
View file

@ -9,4 +9,10 @@ plugin.add_option(
default="initial",
dynamic=True)
@plugin.method('dynamic-option-report')
def record_lookup(plugin):
return {'test-dynamic-config': plugin.get_option('test-dynamic-config')}
plugin.run()

2
tests/test_plugin.py
View file

@ -4314,8 +4314,10 @@ def test_dynamic_option_python_plugin(node_factory):
assert result["configs"]["test-dynamic-config"]["value_str"] == "initial"
assert ln.rpc.dynamic_option_report() == {'test-dynamic-config': 'initial'}
result = ln.rpc.setconfig("test-dynamic-config", "changed")
assert result["config"]["value_str"] == "changed"
assert ln.rpc.dynamic_option_report() == {'test-dynamic-config': 'changed'}
def test_renepay_not_important(node_factory):