tests: run valgrind on children.

This fails on the old dev-restart tests, so we need to only enable it
for the new tests:

	rusty@rusty-XPS-13-9360:~/devel/cvs/lightning (guilt/ping-pong)$ daemon/test/test-basic --restart --verbose
	...
	{  }
	RESTARTING
	dev-restart failed!
	valgrind: mmap(0x38000000, 2265088) failed in UME with error 22 (Invalid argument).
	valgrind: this can be caused by executables with very large text, data or bss segments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2017-04-11 23:52:57 -07:00
parent ba12e316f1
commit 52ee36c595
2 changed files with 2 additions and 2 deletions

View File

@ -16,7 +16,7 @@ PREFIX=$EATMYDATA
# Always use valgrind if available (unless NO_VALGRIND=1 set) # Always use valgrind if available (unless NO_VALGRIND=1 set)
if which valgrind >/dev/null; then :; else NO_VALGRIND=1; fi if which valgrind >/dev/null; then :; else NO_VALGRIND=1; fi
[ -n "$NO_VALGRIND" ] || PREFIX="$EATMYDATA valgrind -q --error-exitcode=7" [ -n "$NO_VALGRIND" ] || PREFIX="$EATMYDATA valgrind -q $VG_TRACE_CHILDREN --trace-children-skip=*bitcoin-cli* --error-exitcode=7"
# We inject 0.01 bitcoin, but then fees (estimatefee fails and we use a # We inject 0.01 bitcoin, but then fees (estimatefee fails and we use a
# fee rate as per the default). # fee rate as per the default).

View File

@ -18,7 +18,7 @@ lightningd/tests: $(LIGHTNINGD_TEST_PROGRAMS:%=unittest/%)
lightningd-test-0-basic: lightningd-test-setup-0 lightningd-test-0-basic: lightningd-test-setup-0
lightningd-test-0-%: lightningd-test-0-%:
NO_VALGRIND=$(NO_VALGRIND) VARIANT=0 lightningd/test/test-$* NO_VALGRIND=$(NO_VALGRIND) VG_TRACE_CHILDREN="--trace-children=yes" VARIANT=0 lightningd/test/test-$*
# We shutdown first in case something is left over. # We shutdown first in case something is left over.
lightningd-test-setup-%: lightningd-all daemon/lightning-cli lightningd-test-setup-%: lightningd-all daemon/lightning-cli