mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-19 09:54:16 +01:00
Code Issues Projects Releases Wiki Activity

test_lightning.py: test for persistence.

Browse Source 
Also note that failing an in-progress payment (instead of waiting) is
pretty weird.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2018-01-18 06:59:49 +10:30 committed by Christian Decker
parent 6ba1bc5c93
commit 469faa476e
2 changed files with 80 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lightningd/pay.c
View File

@ -156,6 +156,7 @@ static bool send_payment(struct command *cmd,
/* Now, do we already have a payment? */
payment = wallet_payment_by_hash(tmpctx, cmd->ld->wallet, rhash);
if (payment) {
/* FIXME: We should really do something smarter here! */
log_debug(cmd->ld->log, "json_sendpay: found previous");
if (payment->status == PAYMENT_PENDING) {
log_add(cmd->ld->log, "... still in progress");

79
tests/test_lightningd.py
View File

@ -2536,6 +2536,85 @@ class LightningDTests(BaseLightningDTests):
# L1 must notice.
l1.daemon.wait_for_log('-> ONCHAIND_THEIR_UNILATERAL')
@unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
def test_payment_success_persistence(self):
# Start two nodes and open a channel.. die during payment.
l1 = self.node_factory.get_node(disconnect=['+WIRE_COMMITMENT_SIGNED'],
options=['--no-reconnect'])
l2 = self.node_factory.get_node()
l1.rpc.connect(l2.info['id'], 'localhost', l2.info['port'])
chanid = self.fund_channel(l1, l2, 100000)
inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')
# Fire off a pay request, it'll get interrupted by a restart
fut = self.executor.submit(l1.rpc.pay, inv1['bolt11'])
l1.daemon.wait_for_log('dev_disconnect: \+WIRE_COMMITMENT_SIGNED')
print("Killing l1 in mid HTLC")
l1.daemon.proc.terminate()
# Restart l1, without disconnect stuff.
l1.daemon.cmd_line.remove('--no-reconnect')
l1.daemon.cmd_line.remove('--dev-disconnect=dev_disconnect')
# Should reconnect, and sort the payment out.
l1.daemon.start()
wait_for(lambda: l1.rpc.listpayments()[0]['status'] != 'pending')
assert l1.rpc.listpayments()[0]['status'] == 'complete'
assert l2.rpc.listinvoice('inv1')[0]['complete'] == True
# FIXME: We should re-add pre-announced routes on startup!
self.wait_for_routes(l1, [chanid])
# A duplicate should succeed immediately (nop) and return correct preimage.
preimage = l1.rpc.pay(inv1['bolt11'])['preimage']
assert l1.rpc.dev_rhash(preimage)['rhash'] == inv1['payment_hash']
@unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
def test_payment_failed_persistence(self):
# Start two nodes and open a channel.. die during payment.
l1 = self.node_factory.get_node(disconnect=['+WIRE_COMMITMENT_SIGNED'],
options=['--no-reconnect'])
l2 = self.node_factory.get_node()
l1.rpc.connect(l2.info['id'], 'localhost', l2.info['port'])
self.fund_channel(l1, l2, 100000)
# Expires almost immediately, so it will fail.
inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1', 1)
# Fire off a pay request, it'll get interrupted by a restart
fut = self.executor.submit(l1.rpc.pay, inv1['bolt11'])
l1.daemon.wait_for_log('dev_disconnect: \+WIRE_COMMITMENT_SIGNED')
print("Killing l1 in mid HTLC")
l1.daemon.proc.terminate()
# Restart l1, without disconnect stuff.
l1.daemon.cmd_line.remove('--no-reconnect')
l1.daemon.cmd_line.remove('--dev-disconnect=dev_disconnect')
# Make sure invoice has expired.
time.sleep(2)
# Should reconnect, and fail the payment
l1.daemon.start()
wait_for(lambda: l1.rpc.listpayments()[0]['status'] != 'pending')
assert l2.rpc.listinvoice('inv1')[0]['complete'] == False
assert l1.rpc.listpayments()[0]['status'] == 'failed'
# Another attempt should also fail.
self.assertRaises(ValueError, l1.rpc.pay, inv1['bolt11'])
@unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
def test_gossip_badsig(self):
l1 = self.node_factory.get_node()