mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-26 20:30:59 +01:00
Code Issues Projects Releases Wiki Activity

renepay: fix shadow route extension logic.

Browse source 
pseudorand(1) is always 0, and capacity test was the wrong way.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2023-08-29 14:59:16 +09:30
parent a234888209
commit 3285aa0eea
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugins/renepay/pay_flow.c
View file

@ -115,7 +115,7 @@ static u32 shadow_one_flow(const struct gossmap *gossmap,
/* We only create shadow for extra CLTV delays, *not* for /* We only create shadow for extra CLTV delays, *not* for
* amounts. This is because with MPP our amounts are random * amounts. This is because with MPP our amounts are random
* looking already. */ * looking already. */
for (hop = 0; hop < MAX_SHADOW_LEN && pseudorand(1); hop++) { for (hop = 0; hop < MAX_SHADOW_LEN && pseudorand(2); hop++) {
/* Try for a believable channel up to 10 times, then stop */ /* Try for a believable channel up to 10 times, then stop */
for (size_t i = 0; i < 10; i++) { for (size_t i = 0; i < 10; i++) {
struct amount_sat cap; struct amount_sat cap;
@ -124,7 +124,7 @@ static u32 shadow_one_flow(const struct gossmap *gossmap,
if (!gossmap_chan_set(chans[hop], dirs[hop]) if (!gossmap_chan_set(chans[hop], dirs[hop])
|| !gossmap_chan_get_capacity(gossmap, chans[hop], &cap) || !gossmap_chan_get_capacity(gossmap, chans[hop], &cap)
/* This test is approximate, since amount would differ */ /* This test is approximate, since amount would differ */
|| amount_msat_less_sat(amount, cap)) { || amount_msat_greater_sat(amount, cap)) {
chans[hop] = NULL; chans[hop] = NULL;
continue; continue;
} }