mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-01-18 05:12:45 +01:00
Code Issues Projects Releases Wiki Activity

peer: fix unassigned error packet on receiving non-ASCII error.

Browse Source 
Reported-by: Lucas Betschart <lucasbetschart@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2016-12-15 11:42:24 +10:30
parent 1b170c85bb
commit 2a68a984c3
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
daemon/peer.c
View File

@ -478,6 +478,15 @@ static bool peer_received_unexpected_pkt(struct peer *peer, const Pkt *pkt,
goto out; goto out;
} }
/* BOLT #2:
*
* A node MUST fail the connection if it receives an `err`
* message, and MUST NOT send an `err` message in this case.
* For other connection failures, a node SHOULD send an
* informative `err` message.
*/
err = NULL;
/* Check packet for weird chars. */ /* Check packet for weird chars. */
for (p = pkt->error->problem; *p; p++) { for (p = pkt->error->problem; *p; p++) {
if (cisprint(*p)) if (cisprint(*p))
@ -491,14 +500,6 @@ static bool peer_received_unexpected_pkt(struct peer *peer, const Pkt *pkt,
} }
log_unusual(peer->log, "Error pkt '%s'", pkt->error->problem); log_unusual(peer->log, "Error pkt '%s'", pkt->error->problem);
/* BOLT #2:
*
* A node MUST fail the connection if it receives an `err`
* message, and MUST NOT send an `err` message in this case.
* For other connection failures, a node SHOULD send an
* informative `err` message.
*/
err = NULL;
out: out:
return peer_comms_err(peer, err); return peer_comms_err(peer, err);
} }