mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2025-03-12 18:49:42 +01:00
Code Issues Projects Releases Wiki Activity

gossipd: fix excessive msg_queue length from status_trace()

Browse source 
When this (very spammy) "handle_recv_gossip" message was changed
from debug to trace, the suppression code wasn't updated: we suppress
overly active debug messages, but not trace messages.

This is the backtrace from an earlier version of the "too large queue"
patch:

```
lightning_gossipd: msg_queue length excessive (version v24.08.1-17-ga780ad4-modded)
0x557e521e833f send_backtrace
        common/daemon.c:33
0x557e521eefb9 do_enqueue
        common/msg_queue.c:66
0x557e521ef043 msg_enqueue
        common/msg_queue.c:82
0x557e521e891d daemon_conn_send
        common/daemon_conn.c:161
0x557e521f14f0 status_send
        common/status.c:90
0x557e521f1804 status_vfmt
        common/status.c:169
0x557e521f1433 status_fmt
        common/status.c:180
0x557e521de7c6 handle_recv_gossip
        gossipd/gossipd.c:206
0x557e521de9f5 connectd_req
        gossipd/gossipd.c:307
0x557e521e862d handle_read
        common/daemon_conn.c:35
```
This commit is contained in:
Rusty Russell 2024-10-28 20:25:58 +10:30
parent 1e4adbff17
commit 1efa0653e1
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
common/status.c
View file

@ -151,7 +151,7 @@ void status_vfmt(enum log_level level,
/* We only suppress async debug msgs. IO messages are even spammier /* We only suppress async debug msgs. IO messages are even spammier
* but they only occur when explicitly asked for */ * but they only occur when explicitly asked for */
if (level == LOG_DBG && status_conn) { if ((level == LOG_DBG || level == LOG_TRACE) && status_conn) {
size_t qlen = daemon_conn_queue_length(status_conn); size_t qlen = daemon_conn_queue_length(status_conn);
/* Once suppressing, we keep suppressing until we're empty */ /* Once suppressing, we keep suppressing until we're empty */
@ -159,7 +159,7 @@ void status_vfmt(enum log_level level,
size_t n = traces_suppressed; size_t n = traces_suppressed;
traces_suppressed = 0; traces_suppressed = 0;
/* Careful: recursion! */ /* Careful: recursion! */
status_debug("...[%zu debug messages suppressed]...", n); status_debug("...[%zu debug/trace messages suppressed]...", n);
} else if (traces_suppressed || qlen > TRACE_QUEUE_LIMIT) { } else if (traces_suppressed || qlen > TRACE_QUEUE_LIMIT) {
traces_suppressed++; traces_suppressed++;
return; return;