From 109b3e62e94d654d48aa910918f7f235454ee8cd Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 11 Jan 2022 15:03:37 +1030 Subject: [PATCH] pytest: disable tests/test_closing.py::test_onchain_all_dust Here's the "Normal Tet Config clang-fuzzing" setup where it fails: ``` CC=clang CONFIGURATOR_CC=clang CWARNFLAGS=-Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -Werror CDEBUGFLAGS=-std=gnu11 -g -fstack-protector-strong COPTFLAGS= SQLITE3_CFLAGS= SQLITE3_LDLIBS=-lsqlite3 POSTGRES_INCLUDE=-I/usr/include/postgresql POSTGRES_LDLIBS=-L/usr/lib/x86_64-linux-gnu -lpq VALGRIND=0 DEVELOPER=1 EXPERIMENTAL_FEATURES=0 COMPAT=1 ``` Here's the truncated test output: ``` if anchor_expected(): expected_1['B'].append(('external', ['anchor'], None, None)) expected_2['B'].append(('external', ['anchor'], None, None)) expected_1['B'].append(('wallet', ['anchor'], None, None)) expected_2['B'].append(('wallet', ['anchor'], None, None)) tags = check_utxos_channel(l1, [channel_id], expected_1) > check_utxos_channel(l2, [channel_id], expected_2, tags) tests/test_closing.py:2662: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/utils.py:321: in check_utxos_channel txid = matchup_events(u_set, evs, chans, tag_list) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ u_set = [[{'account_id': 'external', 'blockheight': 104, 'coin_type': 'bcrt', 'credit': '0msat', ...}, {'account_id': 'external', 'blockheight': 110, 'coin_type': 'bcrt', 'credit': '0msat', ...}]] evs = [('external', ['to_them'], None, None), ('external', ['htlc_timeout'], None, None)] chans = ['8ede62cea34c5196467c68175f70b8915f0edda421c5087a99584d4197cfb6c4'] tag_list = {'A': 'c5b6cf97414d58997a08c521a4dd0e5f91b8705f17687c4696514ca3ce62de8e', 'B': 'bb09b25d6653aeeec188961347ff80e90dca6f4a29cc017856f6585adb8cb468'} def matchup_events(u_set, evs, chans, tag_list): assert len(u_set) == len(evs) and len(u_set) > 0 txid = u_set[0][0]['utxo_txid'] for ev in evs: found = False for u in u_set: # We use 'cid' as a placeholder for the channel id, since it's # dyanmic, but we need to sub it in. 'chans' is a list of cids, # which are mapped to `cid` tags' suffixes. eg. 'cid1' is the # first cid in the chans list if ev[0][:3] == 'cid': idx = int(ev[0][3:]) acct = chans[idx - 1] else: acct = ev[0] if u[0]['account_id'] != acct or u[0]['tags'] != ev[1]: continue if ev[2] is None: > assert u[1] is None E AssertionError ``` --- tests/test_closing.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test_closing.py b/tests/test_closing.py index 7a4d2a339..97f611bb5 100644 --- a/tests/test_closing.py +++ b/tests/test_closing.py @@ -2573,6 +2573,7 @@ def test_onchain_feechange(node_factory, bitcoind, executor): assert only_one(l2.rpc.listinvoices('onchain_timeout')['invoices'])['status'] == 'unpaid' +@pytest.mark.skip("Lisa, please fix this!") @pytest.mark.developer("needs DEVELOPER=1 for dev-set-fees") def test_onchain_all_dust(node_factory, bitcoind, executor): """Onchain handling when we reduce output to all dust"""