mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-19 18:11:28 +01:00
Code Issues Projects Releases Wiki Activity

test_lightningd: fix race in test_closing_different_fees

Browse Source 
fundrawtransaction returns before the actual sendrawtx, so we can
end up mining blocks before it's sent, thus not having enough confirms.

We handle this correctly in fund_channel, but this test open-codes it
for speed with multiple peers.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2018-02-06 12:01:55 +10:30
parent dcafce81ad
commit 07c275e436
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_lightningd.py
View File

@ -1015,7 +1015,7 @@ class LightningDTests(BaseLightningDTests):
num_peers = len(feerates) * len(amounts)
self.give_funds(l1, (10**6) * num_peers + 10000 * num_peers)
# Create them in a batch, but only valgrind one in three, for speed!
# Create them in a batch, for speed!
peers = []
for feerate in feerates:
for amount in amounts:
@ -1029,7 +1029,9 @@ class LightningDTests(BaseLightningDTests):
peers.append(p)
for p in peers:
l1.rpc.fundchannel(p.info['id'], 10**6)
l1.rpc.fundchannel(p.info['id'], 10**6)
# Technically, this is async to fundchannel returning.
l1.daemon.wait_for_log('sendrawtx exit 0')
bitcoind.generate_block(6)