From 02553aa68a4747d59d8ab1a40542dd760805b53f Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 7 Sep 2021 13:36:06 +0930 Subject: [PATCH] plugins/spender: don't use global tal context, use take() instead. Otherwise it looks like a leak. Signed-off-by: Rusty Russell --- plugins/spender/main.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/spender/main.c b/plugins/spender/main.c index 90264ca53..a1f23e050 100644 --- a/plugins/spender/main.c +++ b/plugins/spender/main.c @@ -18,30 +18,28 @@ const char *spender_init(struct plugin *p, const char *b, const jsmntok_t *t) int main(int argc, char **argv) { - char *owner = tal(NULL, char); struct plugin_command *commands; struct plugin_notification *notifs; setup_locale(); - commands = tal_arr(owner, struct plugin_command, 0); + commands = tal_arr(NULL, struct plugin_command, 0); tal_expand(&commands, multiwithdraw_commands, num_multiwithdraw_commands); tal_expand(&commands, fundchannel_commands, num_fundchannel_commands); tal_expand(&commands, multifundchannel_commands, num_multifundchannel_commands); /* tal_expand(&commands, whatever_commands, num_whatever_commands); */ - notifs = tal_arr(owner, struct plugin_notification, 0); + notifs = tal_arr(NULL, struct plugin_notification, 0); tal_expand(¬ifs, openchannel_notifs, num_openchannel_notifs); plugin_main(argv, &spender_init, PLUGIN_STATIC, true, NULL, - commands, tal_count(commands), - notifs, tal_count(notifs), + take(commands), tal_count(commands), + take(notifs), tal_count(notifs), NULL, 0, NULL, 0, /* Notification topics */ NULL); - tal_free(owner); return 0; }