mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-12-29 10:04:41 +01:00
Code Issues Projects Releases Wiki Activity
daba3e7deb
core-lightning/common/Makefile

130 lines
3.6 KiB
Makefile
Raw Normal View History

status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
COMMON_SRC_NOGEN := \
common: pull out scriptPubkey address method We're going to need this for P2WSH scripts. pull it out into a common file plus adopt the sanity checks so that it will allow for either P2WSH or P2WPKH (previously only encoded P2WPKH scripts)
2019-05-22 23:20:14 +02:00
common/addr.c \
common/amount: new types struct amount_msat and struct amount_sat. They're generally used pass-by-copy (unusual for C structs, but convenient they're basically u64) and all possibly problematic operations return WARN_UNUSED_RESULT bool to make you handle the over/underflow cases. The new #include in json.h means we bolt11.c sees the amount.h definition of MSAT_PER_BTC, so delete its local version. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-02-20 12:31:48 +01:00
common/amount.c \
Initial TOR v2/v3 support. This is a rebased and combined patch for Tor support. It is extensively reworked in the following patches, but the basis remains Saibato's work, so it seemed fairest to begin with this. Minor changes: 1. Use --announce-addr instead of --tor-external. 2. I also reverted some whitespace and unrelated changes from the patch. 3. Removed unnecessary ';' after } in functions. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-05-10 01:18:19 +02:00
common/base32.c \
Init commit to be able to create a tor static service on the fly. We want to have a static Tor service created from a blob bound to our node on cmdline Changelog-added: persistent Tor address support Changelog-added: allow the Tor inbound service port differ from 9735 Signed-off-by: Saibato <saibato.naga@pm.me> Add base64 encode/decode to common We need this to encode the blob for the tor service Signed-off-by: Saibato <saibato.naga@pm.me>
2019-11-15 09:44:22 +01:00
common/base64.c \
bech32: move to common/ Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-11-22 01:25:01 +01:00
common/bech32.c \
common: Moving some bech32 related utilities to bech32_util These were so far only used for bolt11 construction, but we'll need them for the DNS seed as well, so here we just pull them out into their own unit and prefix them. Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-04-23 16:20:55 +02:00
common/bech32_util.c \
bigsize: make it a proper first-class type. It doesn't belong in bitcoin, and should not be confused with varint_t. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-07-30 07:25:03 +02:00
common/bigsize.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/bip32.c \
common: add blinding helpers. We'll want this once we add blinded HTLCs. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-04-03 05:16:56 +02:00
common/blinding.c \
bolt11: move to common/ and sign via callback. JSON stuff is moved to lightningd/invoice.c. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-11-22 01:25:39 +01:00
common/bolt11.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/channel_config.c \
common/channel_id: move channel_id into its own file. The definition was in wire/wire.h, and helper functions in fromwire.c! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-05-15 12:29:53 +02:00
common/channel_id.c \
coin_mvt: initial commit for coin movement structs and helpers Fleshes out coin movement structs etc
2020-03-19 00:32:33 +01:00
common/coin_mvt.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/close_tx.c \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/configdir.c \
crypto_state: move to its own file. In particular, the main daemon needs to pass it about (marshal/unmarshal) but it won't need to actually use it after the next patch. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-10-11 11:56:50 +02:00
common/crypto_state.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/crypto_sync.c \
common/cryptomsg.c \
common/daemon: common routines for all daemons. In particular, the main daemon and subdaemons share the backtrace code, with hooks for logging. The daemon hook inserts the io_poll override, which means we no longer need io_debug.[ch]. Though most daemons don't need it, they still link against ccan/io, so it's harmess (suggested by @ZmnSCPxj). This was tested manually to make sure we get backtraces still. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-03-29 04:06:45 +02:00
common/daemon.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/daemon_conn.c \
common: rename decode_short_channel_ids.{c,h} to decode_array.{c.h} This encoding scheme is no longer just used for short_channel_ids, so make the names more generic. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-09-27 02:02:34 +02:00
common/decode_array.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/derive_basepoints.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/dev_disconnect.c \
common: generalize ecdh function. common/onion is going to need to use this for the case where it finds a blinding seed inside the TLV. But how it does ecdh is daemon-specific. We already had this problem for devtools/gossipwith, which supplied a special hsm_do_ecdh(). This just makes it more general. So we create a generic ecdh() interface, with a specific implementation which subdaemons and lightningd can use. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-04-03 05:21:22 +02:00
common/ecdh_hsmd.c \
features: Move feature-handling code to a common/features.c source.
2018-01-12 14:35:52 +01:00
common/features.c \
common: add fee_states state machine for update_fee. This uses the same state machine as HTLCs, but they're only ever added, not removed. Since we can only have one in each state, we use a simple array; mostly NULL. We could make this more space-efficient by folding everything into the first 5 states, but that would be more complex than just using the identical state machine. One subtlety: we don't send uncommitted fee_states over the wire. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-12-12 15:04:53 +01:00
common/fee_states.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/funding_tx.c \
common/gossip_rcvd_filter: cache for received gossip. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-09-06 06:44:05 +02:00
common/gossip_rcvd_filter.c \
common: move gossip_store read routine where subdaemons can access it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-05-04 07:53:13 +02:00
common/gossip_store.c \
common/hash_u5: routines to hash 5 bit values. Needed for creating/verifying signatures on bolt11 invoices. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-10-26 05:00:19 +02:00
common/hash_u5.c \
common: new file hmac for hmac calculation. Blinded paths will want this too; it's mainly copied from sphinx. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-03-20 01:53:21 +01:00
common/hmac.c \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/htlc_state.c \
channeld: extract HTLC trim logic into common. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-05-31 09:30:32 +02:00
common/htlc_trim.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/htlc_tx.c \
common/htlc_wire.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/initial_channel.c \
common/initial_commit_tx.c \
common: Added a small locking mechanism to simplify how we lock IO We've done this a number of times already where we're getting exclusive access to either the out direction of a connection, or we try to lock out the read side while we are responding to a previous request. They usually are really cumbersome because we reach around to the other direction to stop it from proceeding, or we flag our exclusive access somewhere, and we always need to know whom to notify. PR ElementsProject/lightning#1970 adds two new instances of this: - Streaming a JSON response requires that nothing else should write while the stream is active. - We also want to stop reading new requests while we are responding to one. To remove the complexity of having to know whom to stop and notify when we're done, this adds a simple `io_lock` primitive that can be used to get exclusive access to a connection. This inverts the requirement for notifications, since everybody registers interest in the lock and they get notified if the lock holder releases it.
2018-09-26 20:33:28 +02:00
common/io_lock.c \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/json.c \
json: move bitcoin/lightning specific helpers into common/json_helpers. We don't need them in common/json, since lightning-cli doesn't need these, but plugins want them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-01-15 04:54:27 +01:00
common/json_helpers.c \
common: move json_stream from lightningd/ to common/ It's not lightningd-specific and we are going to need it for libplugin. The only drawback is the log_io removal in json_stream_output_write()..
2020-01-20 10:23:55 +01:00
common/json_stream.c \
Move json and param core functionality into common, for plugins. json_escaped.[ch], param.[ch] and jsonrpc_errors.h move from lightningd/ to common/. Tests moved too. We add a new 'common/json_tok.[ch]' for the common parameter parsing routines which a plugin might want, taking them out of lightningd/json.c (which now only contains the lightningd-specific ones). The rest is mainly fixing up includes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-12-08 01:39:28 +01:00
common/json_tok.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/key_derive.c \
common/keyset.c \
common/gossmap: helper to map the gossip store. I went overboard on optimization. I am so sorry: 1. Squeezed channel min/max into 16 bits. 2. Uses mmap and leaves node_ids in the file. 3. Uses offsets instead of pointers where possible. 4. Uses custom free-list to allocate inside arrays. 5. Ignores our autogenerated marshalling code in favor of direct derefs. 6. Carefully aligns everything so we use minimal ram. The result is that the current gossip_store: - load time (-O3 -flto laptop): 40msec - load time (-g laptop i.e. DEVELOPER=0): 60msec - load time (-O0 laptop i.e. DEVELOPER=1): 110msec - Total memory: 2.6MB: - 1.5MB for the array of channels - 512k for the channel htable to map scid -> channel. - 320k for the node htable to map nodeid -> node. - 192k for the array of channels inside each node - 94k for the array of nodes Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-11 08:24:23 +02:00
common/gossmap.c \
lightningd: tal memleak detection, dev-memleak command. This is a primitive mark-and-sweep-style garbage detector. The core is in common/ for later use by subdaemons, but for now it's just lightningd. We initialize it before most other allocations. We walk the tal tree to get all the pointers, then search the `ld` object for those pointers, recursing down. Some specific helpers are required for hashtables (which stash bits in the unused pointer bits, so won't be found). There's `notleak()` for annotating things that aren't leaks: things like globals and timers, and other semi-transients. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-12-15 11:17:54 +01:00
common/memleak.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/msg_queue.c \
common/node_id: new type. Node ids are pubkeys, but we only use them as pubkeys for routing and checking gossip messages. So we're packing and unpacking them constantly, and wasting some space and time. This introduces a new type, explicitly the SEC1 compressed encoding (33 bytes). We ensure its validity when we load from the db, or get it from JSON. We still use 'struct pubkey' for peer messages, which checks validity. Results from 5 runs, min-max(mean +/- stddev): store_load_msec,vsz_kb,store_rewrite_sec,listnodes_sec,listchannels_sec,routing_sec,peer_write_all_sec 39475-39572(39518+/-36),2880732,41.150000-41.390000(41.298+/-0.085),2.260000-2.550000(2.336+/-0.11),44.390000-65.150000(58.648+/-7.5),32.740000-33.020000(32.89+/-0.093),44.130000-45.090000(44.566+/-0.32) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-04-08 08:34:06 +02:00
common/node_id.c \
common: make sphinx code ignorant of payload format. Now "raw_payload" is always the complete string (including realm or length bytes at the front). This has several effects: 1. We can receive an decrypt an onion which is grossly malformed. 2. We can still hand this to the htlc_accepted hook. 3. We then fail it unless the htlc_accepted accepts it manually. 4. The createonion API now takes the raw payload, and does not know anything about "style". The only caveat is that the sphinx code needs to know the payload length: we have a call for that, which simply tells it to copy the entire onion (and treat us as the final node) if it's invalid. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-12-05 11:06:28 +01:00
common/onion.c \
common: add struct onionreply I really want a type which means "I am a wrapped onion reply" as separate from "I am a normal wire msg". Currently both user u8 *, and I got very confused trying to figure out where each one was an unwrapped error msg, or where it still needed (un)wrapping. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-01-22 07:28:25 +01:00
common/onionreply.c \
Move json and param core functionality into common, for plugins. json_escaped.[ch], param.[ch] and jsonrpc_errors.h move from lightningd/ to common/. Tests moved too. We add a new 'common/json_tok.[ch]' for the common parameter parsing routines which a plugin might want, taking them out of lightningd/json.c (which now only contains the lightningd-specific ones). The rest is mainly fixing up includes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-12-08 01:39:28 +01:00
common/param.c \
watchtower: Add a struct containing the penalty base information Suggested-by: Rusty Russell <@rustyrussell>
2020-05-07 02:41:35 +02:00
common/penalty_base.c \
common/per_per_state: generalize lightningd/peer_comm Part 1 Encapsulating the peer state was a win for lightningd; not surprisingly, it's even more of a win for the other daemons, especially as we want to add a little gossip information. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-06-03 20:11:25 +02:00
common/per_peer_state.c \
common: peer_billboard() helper for updating the billboard. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-23 06:53:47 +01:00
common/peer_billboard.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/peer_failed.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/permute_tx.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/ping.c \
psbt-common: shared psbt utilities includes facilities for - sorting psbt inputs by serial_id - sorting psbt outputs by serial_id - adding a serial_id - getting a serial_id - finding the diffset between two psbts - adding a max_len to a psbt input - getting a max_len from a psbt input
2020-07-23 04:15:38 +02:00
common/psbt_open.c \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/pseudorand.c \
common/random_select: central place for reservoir sampling. Turns out we can make quite a simple API out of it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-11 07:05:56 +02:00
common/random_select.c \
common: read_peer_msg helpers for per-peer subds. It's a bit ugly because each caller has slightly different needs, but we have three hooks and standard helpers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-31 03:53:35 +01:00
common/read_peer_msg.c \
setup: create a common setup which will handle the wally-context Since we now over-write the wally malloc/free functions, we need to do so for tests as well. Here we pull up all of the common setup/teardown logic into a separate place, and update the tests that use libwally to use the new common_setup core Changelog-None
2020-05-16 00:13:22 +02:00
common/setup.c \
closingd: Ensure proper closing of TCP socket. Fixes: #1457
2018-05-05 06:57:58 +02:00
common/socket_close.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/sphinx.c \
common/status.c \
status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
common/status_wire.c \
subdaemon.c: subdaemon_setup() routine for all daemons. Our handling of SIGPIPE was incoherent and inconsistent, and we had much cut & paste between the daemons. They should *ALL* ignore SIGPIPE, and much of the rest of the boilerplate can be shared, so should be. Reported-by: @ZmnSCPxj Fixes: #528 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-01-08 11:01:09 +01:00
common/subdaemon.c \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/timeout.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/type_to_string.c \
common/utils.c \
common: move some files out of lightningd/ Basically all files shared by different daemons. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:05:01 +02:00
common/utxo.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/version.c \
wallet: Rip out the txtypes type in favor of enum wallet_tx_type Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <decker.christian@gmail.com>
2019-06-07 11:38:20 +02:00
common/wallet.c \
Removed redundancies in withdraw and fundchannel. No new functionality, just a continuation of my work toward completing #665. I removed the common members of `struct withdrawal` and `struct fund_channel` and placed them in a new `struct wallet_tx`. Then it was fairly straightforward to reimplement the existing code in terms of `wallet_tx`. Since I made some structural changes I wanted to get this approved before I go any farther. Added 'all' to fundchannel help message.
2018-04-05 21:19:47 +02:00
common/wallet_tx.c \
ipaddr: rename to wireaddr. In future it will have TOR support, so the name will be awkward. We collect the to/fromwire functions in common/wireaddr.c, and the parsing functions in lightningd/netaddress.c. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-10-23 06:17:38 +02:00
common/wireaddr.c \
common/wire_error: helpers to create/parse WIRE_ERROR messages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-10-11 12:01:50 +02:00
common/wire_error.c \
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
common/withdraw_tx.c
common: convert to new wire generation style. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-25 04:19:38 +02:00
COMMON_SRC_GEN := common/status_wiregen.c common/peer_status_wiregen.c
status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
Use dedicated type for error codes Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2
2020-01-26 13:52:29 +01:00
COMMON_HEADERS_NOGEN := $(COMMON_SRC_NOGEN:.c=.h) \
closingd: configurable closing fee negotiation step When negotiating the transaction fee for closing a channel [1], we used to always pick the middle of the range between our proposal and the peer's proposal. Introduce a new option `fee_negotiation_step` to the close command, so the peer who initiates the close can choose his back off step. Partially resolves https://github.com/ElementsProject/lightning/issues/3270 [1] https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#closing-negotiation-closing_signed Changelog-Added: New optional parameter to the `close` command to control the closing transaction fee negotiation back off step
2020-01-03 14:08:29 +01:00
common/closing_fee.h \
common: generalize ecdh function. common/onion is going to need to use this for the case where it finds a blinding seed inside the TLV. But how it does ecdh is daemon-specific. We already had this problem for devtools/gossipwith, which supplied a special hsm_do_ecdh(). This just makes it more general. So we create a generic ecdh() interface, with a specific implementation which subdaemons and lightningd can use. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-04-03 05:21:22 +02:00
common/ecdh.h \
Use dedicated type for error codes Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2
2020-01-26 13:52:29 +01:00
common/errcode.h \
common/gossip_constants.h \
common/htlc.h \
common/json_command.h \
common/jsonrpc_errors.h \
common/overflows.h \
common/status_levels.h
common: convert to new wire generation style. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-25 04:19:38 +02:00
COMMON_HEADERS_GEN := common/gen_htlc_state_names.h common/status_wiregen.h common/peer_status_wiregen.h
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
COMMON_HEADERS := $(COMMON_HEADERS_GEN) $(COMMON_HEADERS_NOGEN)
status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
COMMON_SRC := $(COMMON_SRC_NOGEN) $(COMMON_SRC_GEN)
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
COMMON_OBJS := $(COMMON_SRC:.c=.o)
Makefiles: simplify dependencies. Gather all binaries and objects and make the depend on external requirements and common headers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:13:01 +02:00
# Common objects depends on bitcoin/ external/ and ccan
$(COMMON_OBJS): $(CCAN_HEADERS) $(BITCOIN_HEADERS) $(EXTERNAL_HEADERS) $(COMMON_HEADERS_GEN)
Makefile: Remove gen_version.h from ALL_GEN_HEADERS. This prevents recompiling everything when you are changing just a doc, or touching only one file among hundreds of sources, just because the `gen_version.h` is changed, especially since only one source actually depends on that header.
2020-08-05 16:26:16 +02:00
# Only common/version.c can include this header.
common/version.o: gen_version.h
Rename subdaemons, move them into top level. We leave the *build* results in lightningd/ for ease of in-place testing though. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-29 06:12:04 +02:00
ALL_GEN_HEADERS += $(COMMON_HEADERS_GEN)
ALL_OBJS += $(COMMON_OBJS)
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
common/gen_htlc_state_names.h: common/htlc_state.h ccan/ccan/cdump/tools/cdump-enumstr
ccan/ccan/cdump/tools/cdump-enumstr common/htlc_state.h > $@
common/gossmap: helper to map the gossip store. I went overboard on optimization. I am so sorry: 1. Squeezed channel min/max into 16 bits. 2. Uses mmap and leaves node_ids in the file. 3. Uses offsets instead of pointers where possible. 4. Uses custom free-list to allocate inside arrays. 5. Ignores our autogenerated marshalling code in favor of direct derefs. 6. Carefully aligns everything so we use minimal ram. The result is that the current gossip_store: - load time (-O3 -flto laptop): 40msec - load time (-g laptop i.e. DEVELOPER=0): 60msec - load time (-O0 laptop i.e. DEVELOPER=1): 110msec - Total memory: 2.6MB: - 1.5MB for the array of channels - 512k for the channel htable to map scid -> channel. - 320k for the node htable to map nodeid -> node. - 192k for the array of channels inside each node - 94k for the array of nodes Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-11 08:24:23 +02:00
common/gossip_store.o: gossipd/gossip_store_wiregen.h
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
check-makefile: check-common-makefile
check-common-makefile:
common: convert to new wire generation style. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-08-25 04:19:38 +02:00
if [ x"`LC_ALL=C ls common/*.h | grep -v ^common/gen_ | grep -v '^common/.*wiregen'`" != x"`echo $(COMMON_HEADERS_NOGEN) | tr ' ' '\n' | LC_ALL=C sort`" ]; then echo COMMON_HEADERS_NOGEN incorrect; exit 1; fi
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
check-source-bolt: $(COMMON_SRC_NOGEN:%=bolt-check/%) $(COMMON_HEADERS:%=bolt-check/%)
check-whitespace: $(COMMON_SRC_NOGEN:%=check-whitespace/%) $(COMMON_HEADERS:%=check-whitespace/%)
common: new directory for any shared objects. To avoid everything pulling in HTLCs stuff to the opening daemon, we split the channel and commit_tx routines into initial_channel and initial_commit_tx (no HTLC support) and move full HTLC supporting versions into channeld. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:02:01 +02:00
status: generate messages rather than marshal/unmarshal manually. Now we have wirestring, this is much more natural. And with the 24M length limit, we needn't be so concerned about dumping 64k peer messages in hex. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-02-08 02:25:12 +01:00
check-source: $(COMMON_SRC_NOGEN:%=check-src-include-order/%) \
common: absorb remaining files from daemon/ Also, we split the more sophisticated json_add helpers to avoid pulling in everything into lightning-cli, and unify the routines to print struct short_channel_id (it's ':', not '/' too). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:04:01 +02:00
$(COMMON_HEADERS_NOGEN:%=check-hdr-include-order/%)
Makefiles: simplify dependencies. Gather all binaries and objects and make the depend on external requirements and common headers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:13:01 +02:00
Makefile: clean needs to do more, distclean should remove everything. I checked this with git status --ignored after a full build and 'make distclean'. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-11-23 04:03:07 +01:00
clean: common-clean
common-clean:
$(RM) common/gen*
Makefiles: simplify dependencies. Gather all binaries and objects and make the depend on external requirements and common headers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-08-28 18:13:01 +02:00
include common/test/Makefile
Reference in New Issue Copy Permalink