mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-12-28 17:44:47 +01:00
Code Issues Projects Releases Wiki Activity
c34639252b
core-lightning/lightningd/pay.h

38 lines
1.2 KiB
C
Raw Normal View History

lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
#ifndef LIGHTNING_LIGHTNINGD_PAY_H
#define LIGHTNING_LIGHTNINGD_PAY_H
#include "config.h"
Use dedicated type for error codes Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2
2020-01-26 13:52:29 +01:00
#include <common/errcode.h>
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
lightningd: explictly split htlc_in and htlc_out. They share some fields, but they're basically different, and it's clearest to treat them differently in most places. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-06-20 07:53:03 +02:00
struct htlc_out;
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
struct lightningd;
common: use struct onionreply. This makes it clear we're dealing with a message which is a wrapped error reply (needing unwrap_onionreply), not an already-wrapped one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-01-23 00:38:04 +01:00
struct onionreply;
lightningd: move pay internals back into pay.c Now we don't have a second caller for these routines, we can move them back into pay.c and make the functions static. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-01-17 16:25:32 +01:00
struct preimage;
payalgo: New file for pay command.
2018-02-15 04:32:03 +01:00
struct sha256;
plugin: A new notification type, 'sendpay_success' `sendpay_success` A notification for topic `sendpay_success` is sent every time a sendpay success(with `complete` status). The json is same as the return value of command `sendpay`/`waitsendpay` when these cammand succeeds. ```json { "sendpay_success": { "id": 1, "payment_hash": "5c85bf402b87d4860f4a728e2e58a2418bda92cd7aea0ce494f11670cfbfb206", "destination": "035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d", "msatoshi": 100000000, "amount_msat": "100000000msat", "msatoshi_sent": 100001001, "amount_sent_msat": "100001001msat", "created_at": 1561390572, "status": "complete", "payment_preimage": "9540d98095fd7f37687ebb7759e733934234d4f934e34433d4998a37de3733ee" } } ``` `sendpay` doesn't wait for the result of sendpay and `waitsendpay` returns the result of sendpay in specified time or timeout, but `sendpay_success` will always return the result anytime when sendpay successes if is was subscribed.
2019-06-25 09:27:35 +02:00
struct json_stream;
struct wallet_payment;
pay: Warp the json process of payment fail field We will also call this warped function in the json process of the 'sendpay_failure' notification.
2019-06-25 09:55:09 +02:00
struct routing_failure;
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
lightningd: explictly split htlc_in and htlc_out. They share some fields, but they're basically different, and it's clearest to treat them differently in most places. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-06-20 07:53:03 +02:00
void payment_succeeded(struct lightningd *ld, struct htlc_out *hout,
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
const struct preimage *rval);
lightningd: don't report spurious temporary_node_failure on local failures. I noticed the following in logs for tests/test_connection.py::test_feerate_stress: ``` DEBUG 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: Failing HTLC 18446744073709551615 due to peer death DEBUG 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: local_routing_failure: 8194 (WIRE_TEMPORARY_NODE_FAILURE) ``` This is because it reports the (transient) node_failure error, because our channel_failure message is incomplete. Fix this wart up. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-05-04 09:19:53 +02:00
/* failmsg_needs_update is if we actually wanted to temporary_channel_failure
* but we haven't got the update msg yet */
lightningd: unify pay vs forward path when handling failures. It's a bit tricky since we want to hand more verbose errors to the local case, but the locally-created and forwarded paths had diverged (the local one missing some things). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-06-20 08:12:03 +02:00
void payment_failed(struct lightningd *ld, const struct htlc_out *hout,
lightningd: don't report spurious temporary_node_failure on local failures. I noticed the following in logs for tests/test_connection.py::test_feerate_stress: ``` DEBUG 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: Failing HTLC 18446744073709551615 due to peer death DEBUG 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: local_routing_failure: 8194 (WIRE_TEMPORARY_NODE_FAILURE) ``` This is because it reports the (transient) node_failure error, because our channel_failure message is incomplete. Fix this wart up. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-05-04 09:19:53 +02:00
const char *localfail, const u8 *failmsg_needs_update);
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
pay: Add hook for triggering storage of payments.
2018-03-10 07:39:11 +01:00
/* Inform payment system to save the payment. */
pay: Invert ownership of wallet_payment `wallet_payment_store` would free the `wallet_payment` instance which would then cause us to reload it from the DB. Instead of doing the store->free->load dance we now tell `wallet_payment_store` whether it should take ownership and leave it alone if not. Passing the payment around instead of referencing it through payment_hash and partid is a nice side-effect.
2020-01-07 21:00:51 +01:00
void payment_store(struct lightningd *ld, struct wallet_payment *payment);
pay: Add hook for triggering storage of payments.
2018-03-10 07:39:11 +01:00
plugin: A new notification type, 'sendpay_success' `sendpay_success` A notification for topic `sendpay_success` is sent every time a sendpay success(with `complete` status). The json is same as the return value of command `sendpay`/`waitsendpay` when these cammand succeeds. ```json { "sendpay_success": { "id": 1, "payment_hash": "5c85bf402b87d4860f4a728e2e58a2418bda92cd7aea0ce494f11670cfbfb206", "destination": "035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d", "msatoshi": 100000000, "amount_msat": "100000000msat", "msatoshi_sent": 100001001, "amount_sent_msat": "100001001msat", "created_at": 1561390572, "status": "complete", "payment_preimage": "9540d98095fd7f37687ebb7759e733934234d4f934e34433d4998a37de3733ee" } } ``` `sendpay` doesn't wait for the result of sendpay and `waitsendpay` returns the result of sendpay in specified time or timeout, but `sendpay_success` will always return the result anytime when sendpay successes if is was subscribed.
2019-06-25 09:27:35 +02:00
/* This json will be also used in 'sendpay_success' notifictaion. */
void json_add_payment_fields(struct json_stream *response,
const struct wallet_payment *t);
pay: Warp the json process of payment fail field We will also call this warped function in the json process of the 'sendpay_failure' notification.
2019-06-25 09:55:09 +02:00
/* This json will be also used in 'sendpay_failure' notifictaion. */
void json_sendpay_fail_fields(struct json_stream *js,
API: Add payment fields(if not NULL) into return value when sendpay fails pPayment field includes the basic information of the payment, so the return valves of 'sendpay_success()' and 'sendpay_fail()' should include this field. Note "immediate_routing_failure" is before payment creation, and for this case, return won't include payment fields.
2019-08-11 15:29:16 +02:00
const struct wallet_payment *t,
Use dedicated type for error codes Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2
2020-01-26 13:52:29 +01:00
errcode_t pay_errcode,
common: use struct onionreply. This makes it clear we're dealing with a message which is a wrapped error reply (needing unwrap_onionreply), not an already-wrapped one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2020-01-23 00:38:04 +01:00
const struct onionreply *onionreply,
pay: Warp the json process of payment fail field We will also call this warped function in the json process of the 'sendpay_failure' notification.
2019-06-25 09:55:09 +02:00
const struct routing_failure *fail);
lightning/pay: fix missing include. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2017-04-02 22:37:56 +02:00
#endif /* LIGHTNING_LIGHTNINGD_PAY_H */
Reference in New Issue Copy Permalink