mirrors/core-lightning
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2024-11-20 02:27:51 +01:00
Code Issues Projects Releases Wiki Activity
43edd91440
core-lightning/common/jsonrpc_errors.h

50 lines
1.5 KiB
C
Raw Normal View History

Move json and param core functionality into common, for plugins. json_escaped.[ch], param.[ch] and jsonrpc_errors.h move from lightningd/ to common/. Tests moved too. We add a new 'common/json_tok.[ch]' for the common parameter parsing routines which a plugin might want, taking them out of lightningd/json.c (which now only contains the lightningd-specific ones). The rest is mainly fixing up includes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-12-08 01:39:28 +01:00
/* common/jsonrpc_errors.h
jsonrpc_errors.h: Header for JSON-RPC errors.
2018-02-05 02:19:16 +01:00
* Lists error codes for JSON-RPC.
*/
Move json and param core functionality into common, for plugins. json_escaped.[ch], param.[ch] and jsonrpc_errors.h move from lightningd/ to common/. Tests moved too. We add a new 'common/json_tok.[ch]' for the common parameter parsing routines which a plugin might want, taking them out of lightningd/json.c (which now only contains the lightningd-specific ones). The rest is mainly fixing up includes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-12-08 01:39:28 +01:00
#ifndef LIGHTNING_COMMON_JSONRPC_ERRORS_H
#define LIGHTNING_COMMON_JSONRPC_ERRORS_H
jsonrpc_errors.h: Header for JSON-RPC errors.
2018-02-05 02:19:16 +01:00
#include "config.h"
Fix typos
2018-02-08 22:49:35 +01:00
/* Standard errors defined by JSON-RPC 2.0 standard */
jsonrpc_errors.h: Header for JSON-RPC errors.
2018-02-05 02:19:16 +01:00
#define JSONRPC2_INVALID_REQUEST -32600
#define JSONRPC2_METHOD_NOT_FOUND -32601
#define JSONRPC2_INVALID_PARAMS -32602
Added error code parameter to command_fail Until now, `command_fail()` reported an error code of -1 for all uses. This PR adds an `int code` parameter to `command_fail()`, requiring the caller to explicitly include the error code. This is part of #1464. The majority of the calls are used during parameter validation and their error code is now JSONRPC2_INVALID_PARAMS. The rest of the calls report an error code of LIGHTNINGD, which I defined to -1 in `jsonrpc_errors.h`. The intention here is that as we improve our error reporting, all occurenaces of LIGHTNINGD will go away and we can eventually remove it. I also converted calls to `command_fail_detailed()` that took a `NULL` `data` parameter to use the new `command_fail()`. The only difference from an end user perspecive is that bad input errors that used to be -1 will now be -32602 (JSONRPC2_INVALID_PARAMS).
2018-05-24 23:40:18 +02:00
/* Uncategorized error.
* FIXME: This should be replaced in all places
* with a specific error code, and then removed.
*/
#define LIGHTNINGD -1
renamed error code Signed-off-by: Mark Beckwith <wythe@intrig.com>
2018-07-28 19:34:17 +02:00
/* Developer error in the parameters to param() call */
#define PARAM_DEV_ERROR -2
Added error code parameter to command_fail Until now, `command_fail()` reported an error code of -1 for all uses. This PR adds an `int code` parameter to `command_fail()`, requiring the caller to explicitly include the error code. This is part of #1464. The majority of the calls are used during parameter validation and their error code is now JSONRPC2_INVALID_PARAMS. The rest of the calls report an error code of LIGHTNINGD, which I defined to -1 in `jsonrpc_errors.h`. The intention here is that as we improve our error reporting, all occurenaces of LIGHTNINGD will go away and we can eventually remove it. I also converted calls to `command_fail_detailed()` that took a `NULL` `data` parameter to use the new `command_fail()`. The only difference from an end user perspecive is that bad input errors that used to be -1 will now be -32602 (JSONRPC2_INVALID_PARAMS).
2018-05-24 23:40:18 +02:00
plugin: Map results back to the incoming JSON-RPC request The final step in the JSON-RPC passthrough: map the result we got from the plugin back to the original request we got from the client. Signed-off-by: Christian Decker <decker.christian@gmail.com>
2018-11-26 19:54:06 +01:00
/* Plugin returned an error */
#define PLUGIN_ERROR -3
pay: Make sendpay nonblocking.
2018-03-04 06:35:37 +01:00
/* Errors from `pay`, `sendpay`, or `waitsendpay` commands */
pay: Provide detailed errors on `sendpay` or `pay` failure. Fixes: #866
2018-02-03 12:46:12 +01:00
#define PAY_IN_PROGRESS 200
#define PAY_RHASH_ALREADY_USED 201
#define PAY_UNPARSEABLE_ONION 202
#define PAY_DESTINATION_PERM_FAIL 203
#define PAY_TRY_OTHER_ROUTE 204
#define PAY_ROUTE_NOT_FOUND 205
#define PAY_ROUTE_TOO_EXPENSIVE 206
payalgo: Create a new failure for paying expired invoice.
2018-02-17 08:34:31 +01:00
#define PAY_INVOICE_EXPIRED 207
pay: Make sendpay nonblocking.
2018-03-04 06:35:37 +01:00
#define PAY_NO_SUCH_PAYMENT 208
#define PAY_UNSPECIFIED_ERROR 209
payalgo: Implement retry_for for pay command.
2018-03-11 15:30:34 +01:00
#define PAY_STOPPED_RETRYING 210
pay: Provide detailed errors on `sendpay` or `pay` failure. Fixes: #866
2018-02-03 12:46:12 +01:00
Added wallet related error codes New codes: FUND_MAX_EXCEEDED, FUND_CANNOT_AFFORD, FUND_DUST_LIMIT_UNMET. The error message "Cannot afford fee" was not exactly correct because it would also occur if the amount requested could not be afforded. So I changed it to the more generic "Cannot afford transaction". Other things: * Fixed off-by-one satoshi in fundchannel manpage. * Changed 'arror' to 'error' because we are not pirates.
2018-06-15 18:45:06 +02:00
/* `fundchannel` or `withdraw` errors */
#define FUND_MAX_EXCEEDED 300
#define FUND_CANNOT_AFFORD 301
wallet: clarify error 302. "Dust limit unmet" seems undescriptive to me. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-06-17 06:48:12 +02:00
#define FUND_OUTPUT_IS_DUST 302
openingd/json_fund_channel: - result fundchannel command now depends on successful or failed broadcast of the funding tx - failure returns error code FUNDING_BROADCAST_FAIL - don't fail the channel when broadcast failed, but keep in CHANNELD_AWAITING_LOCKIN - after fixing the initial broadcast failure, the user could manually rebroadcast the tx and keep the channel openingd/opening_funder_finished: - broadcast_tx callback function now handles both success and failure jsonrpc: added error code FUNDING_BROADCAST_FAIL manpage: added error code returned by fundchannel command This makes the user more aware of broadcast failure, so it hopefully doesn't try to broadcast new tx's that depend on its change_outputs. Some users have reported (see issue #2171) a whole sequence of fundings failing, because each funding was using the change output of the previous one, which would not confirm.
2019-01-16 14:24:30 +01:00
#define FUNDING_BROADCAST_FAIL 303
funding: don't allow funding new channels until we're synced. This is probably worth preventing. 1. Our depth estimate would be inaccurate possibly leading to us timing out too early. 2. If we're not up-to-date our onchain funds are unknown. 3. We wouldn't be able to send or receive HTLCs until we're synced anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-08-10 12:48:20 +02:00
#define FUNDING_STILL_SYNCING_BITCOIN 304
Added wallet related error codes New codes: FUND_MAX_EXCEEDED, FUND_CANNOT_AFFORD, FUND_DUST_LIMIT_UNMET. The error message "Cannot afford fee" was not exactly correct because it would also occur if the amount requested could not be afforded. So I changed it to the more generic "Cannot afford transaction". Other things: * Fixed off-by-one satoshi in fundchannel manpage. * Changed 'arror' to 'error' because we are not pirates.
2018-06-15 18:45:06 +02:00
invoice: Define specific error codes for duplicate label and preimage.
2018-04-26 09:42:04 +02:00
/* Errors from `invoice` command */
#define INVOICE_LABEL_ALREADY_EXISTS 900
#define INVOICE_PREIMAGE_ALREADY_EXISTS 901
Move json and param core functionality into common, for plugins. json_escaped.[ch], param.[ch] and jsonrpc_errors.h move from lightningd/ to common/. Tests moved too. We add a new 'common/json_tok.[ch]' for the common parameter parsing routines which a plugin might want, taking them out of lightningd/json.c (which now only contains the lightningd-specific ones). The rest is mainly fixing up includes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2018-12-08 01:39:28 +01:00
#endif /* LIGHTNING_COMMON_JSONRPC_ERRORS_H */
Reference in New Issue Copy Permalink