core-lightning/connectd/netaddress.h

#ifndef LIGHTNING_CONNECTD_NETADDRESS_H
#define LIGHTNING_CONNECTD_NETADDRESS_H
#include "config.h"
#include <common/wireaddr.h>

/* Address is a wildcard: try to guess what it looks like to outside world */
bool guess_address(struct wireaddr *wireaddr);

/* Is this address public? */
bool address_routable(const struct wireaddr *wireaddr,
		      bool allow_localhost);

#endif /* LIGHTNING_CONNECTD_NETADDRESS_H */
gossipd: move files into connectd. These source files are only used for peer-related things, so move them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-07-24 08:18:58 +02:00			`#ifndef LIGHTNING_CONNECTD_NETADDRESS_H`
			`#define LIGHTNING_CONNECTD_NETADDRESS_H`
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:21 +02:00			`#include "config.h"`
gossipd/lightningd: use wireaddr_internal. This replacement is a little menial, but it explicitly catches all the places where we allow a local socket. The actual implementation of opening a AF_UNIX socket is almost hidden in the patch. The detection of "valid address" is now more complex: p->addr.itype != ADDR_INTERNAL_WIREADDR \|\| p->addr.u.wireaddr.type != ADDR_TYPE_PADDING But most places we do this, we should audit: I'm pretty sure we can't get an invalid address any more from gossipd (they may be in db, but we should fix that too). Closes: #1323 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:21 +02:00			`#include <common/wireaddr.h>`
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:21 +02:00
gossipd: handle wildcard addresses correctly. If we're given a wildcard address, we can't announce it like that: we need to try to turn it into a real address (using guess_address). Then we use that address. As a side-effect of this cleanup, we only announce any '--addr' if it's routable. This fix means that our tests have to force '--announce-addr' because otherwise localhost isn't routable. This means that gossipd really controls the addresses now, and breaks them into two arrays: what we bind to, and what we announce. That is now what we return to the master for json_getinfo(), which prints them as 'bindings' and 'addresses' respectively. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:22 +02:00			`/* Address is a wildcard: try to guess what it looks like to outside world */`
			`bool guess_address(struct wireaddr *wireaddr);`

			`/* Is this address public? */`
gossipd: don't try to connect to non-routable addresses. Someone could try to announce an internal address, and we might probe it. This breaks tests, so we add '--dev-allow-localhost' for our tests, so we don't eliminate that one. Of course, now we need to skip some more tests in non-developer mode. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:22 +02:00			`bool address_routable(const struct wireaddr *wireaddr,`
			`bool allow_localhost);`
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-05-07 06:29:21 +02:00
gossipd: move files into connectd. These source files are only used for peer-related things, so move them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2018-07-24 08:18:58 +02:00			`#endif /* LIGHTNING_CONNECTD_NETADDRESS_H */`