common/node_id: new type.
Node ids are pubkeys, but we only use them as pubkeys for routing and checking
gossip messages. So we're packing and unpacking them constantly, and wasting
some space and time.
This introduces a new type, explicitly the SEC1 compressed encoding
(33 bytes). We ensure its validity when we load from the db, or get it
from JSON. We still use 'struct pubkey' for peer messages, which checks
validity.
Results from 5 runs, min-max(mean +/- stddev):
store_load_msec,vsz_kb,store_rewrite_sec,listnodes_sec,listchannels_sec,routing_sec,peer_write_all_sec
39475-39572(39518+/-36),2880732,41.150000-41.390000(41.298+/-0.085),2.260000-2.550000(2.336+/-0.11),44.390000-65.150000(58.648+/-7.5),32.740000-33.020000(32.89+/-0.093),44.130000-45.090000(44.566+/-0.32)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-04-08 08:34:06 +02:00
|
|
|
/* Encapsulation for pubkeys used as node ids: more compact, more dangerous. */
|
|
|
|
#ifndef LIGHTNING_COMMON_NODE_ID_H
|
|
|
|
#define LIGHTNING_COMMON_NODE_ID_H
|
|
|
|
#include "config.h"
|
|
|
|
#include <bitcoin/pubkey.h>
|
|
|
|
|
|
|
|
struct node_id {
|
|
|
|
u8 k[PUBKEY_CMPR_LEN];
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline bool node_id_eq(const struct node_id *a,
|
|
|
|
const struct node_id *b)
|
|
|
|
{
|
|
|
|
return memcmp(a->k, b->k, sizeof(a->k)) == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Is this actually a valid pubkey? Relatively expensive. */
|
|
|
|
bool node_id_valid(const struct node_id *id);
|
|
|
|
|
|
|
|
/* Convert from pubkey to compressed pubkey. */
|
|
|
|
void node_id_from_pubkey(struct node_id *id, const struct pubkey *key);
|
|
|
|
|
|
|
|
/* Returns false if not a valid pubkey: relatively expensive */
|
|
|
|
WARN_UNUSED_RESULT
|
|
|
|
bool pubkey_from_node_id(struct pubkey *key, const struct node_id *id);
|
|
|
|
|
2020-12-05 03:17:54 +01:00
|
|
|
/* Returns false if not a valid pubkey: relatively expensive */
|
|
|
|
WARN_UNUSED_RESULT
|
2021-10-08 00:54:42 +02:00
|
|
|
bool point32_from_node_id(struct point32 *key, const struct node_id *id);
|
2020-12-05 03:17:54 +01:00
|
|
|
|
common/node_id: new type.
Node ids are pubkeys, but we only use them as pubkeys for routing and checking
gossip messages. So we're packing and unpacking them constantly, and wasting
some space and time.
This introduces a new type, explicitly the SEC1 compressed encoding
(33 bytes). We ensure its validity when we load from the db, or get it
from JSON. We still use 'struct pubkey' for peer messages, which checks
validity.
Results from 5 runs, min-max(mean +/- stddev):
store_load_msec,vsz_kb,store_rewrite_sec,listnodes_sec,listchannels_sec,routing_sec,peer_write_all_sec
39475-39572(39518+/-36),2880732,41.150000-41.390000(41.298+/-0.085),2.260000-2.550000(2.336+/-0.11),44.390000-65.150000(58.648+/-7.5),32.740000-33.020000(32.89+/-0.093),44.130000-45.090000(44.566+/-0.32)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-04-08 08:34:06 +02:00
|
|
|
/* Convert to hex string of SEC1 encoding. */
|
|
|
|
char *node_id_to_hexstr(const tal_t *ctx, const struct node_id *id);
|
|
|
|
|
|
|
|
/* Convert from hex string of SEC1 encoding: checks validity! */
|
|
|
|
bool node_id_from_hexstr(const char *str, size_t slen, struct node_id *id);
|
|
|
|
|
|
|
|
/* Compare the keys `a` and `b`. Return <0 if `a`<`b`, 0 if equal and >0 otherwise */
|
|
|
|
int node_id_cmp(const struct node_id *a, const struct node_id *b);
|
|
|
|
|
|
|
|
/* If the two nodes[] are id1 and id2, which index would id1 be? */
|
|
|
|
static inline int node_id_idx(const struct node_id *id1,
|
|
|
|
const struct node_id *id2)
|
|
|
|
{
|
|
|
|
return node_id_cmp(id1, id2) > 0;
|
|
|
|
}
|
|
|
|
|
2020-05-16 03:29:05 +02:00
|
|
|
/* marshal/unmarshal functions */
|
|
|
|
void towire_node_id(u8 **pptr, const struct node_id *id);
|
|
|
|
void fromwire_node_id(const u8 **cursor, size_t *max, struct node_id *id);
|
common/node_id: new type.
Node ids are pubkeys, but we only use them as pubkeys for routing and checking
gossip messages. So we're packing and unpacking them constantly, and wasting
some space and time.
This introduces a new type, explicitly the SEC1 compressed encoding
(33 bytes). We ensure its validity when we load from the db, or get it
from JSON. We still use 'struct pubkey' for peer messages, which checks
validity.
Results from 5 runs, min-max(mean +/- stddev):
store_load_msec,vsz_kb,store_rewrite_sec,listnodes_sec,listchannels_sec,routing_sec,peer_write_all_sec
39475-39572(39518+/-36),2880732,41.150000-41.390000(41.298+/-0.085),2.260000-2.550000(2.336+/-0.11),44.390000-65.150000(58.648+/-7.5),32.740000-33.020000(32.89+/-0.093),44.130000-45.090000(44.566+/-0.32)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2019-04-08 08:34:06 +02:00
|
|
|
#endif /* LIGHTNING_COMMON_NODE_ID_H */
|