mirrors/btcpayserver
1
0
Fork 0
mirror of https://github.com/btcpayserver/btcpayserver.git synced 2025-02-20 13:34:37 +01:00
Code Issues Projects Releases Packages Wiki Activity

Allow any bolt11 invoice for pullpayments/payouts (#4857)

Browse source 
closes #4830

If users want to deal with expired payout destinations, then they should be able to conifugre it that way. Some wallets simply do not allow customizing the bolt11 expiry and the defaults are much less than a day. I think we should merge #3857 if we introduce this as an automated payotu processor for lightning running every few minutes would work together with this and solve it.
This commit is contained in:
Andrew Camilleri 2023-04-06 08:54:19 +02:00 • committed by GitHub
parent b24764d679
commit e239390ebf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
BTCPayServer/Controllers/GreenField/GreenfieldPullPaymentController.cs
View file

@ -115,7 +115,7 @@ namespace BTCPayServer.Controllers.Greenfield
{
ModelState.AddModelError(nameof(request.Period), $"The period should be positive");
}
if (request.BOLT11Expiration <= TimeSpan.Zero)
if (request.BOLT11Expiration < TimeSpan.Zero)
{
ModelState.AddModelError(nameof(request.BOLT11Expiration), $"The BOLT11 expiration should be positive");
}
@ -142,7 +142,7 @@ namespace BTCPayServer.Controllers.Greenfield
}
if (!ModelState.IsValid)
return this.CreateValidationError(ModelState);
var ppId = await _pullPaymentService.CreatePullPayment(new HostedServices.CreatePullPayment()
var ppId = await _pullPaymentService.CreatePullPayment(new CreatePullPayment()
{
StartsAt = request.StartsAt,
ExpiresAt = request.ExpiresAt,

1
BTCPayServer/HostedServices/PullPaymentHostedService.cs
View file

@ -120,6 +120,7 @@ namespace BTCPayServer.HostedServices
o.Period = create.Period is TimeSpan period ? (long?)period.TotalSeconds : null;
o.Id = Encoders.Base58.EncodeData(RandomUtils.GetBytes(20));
o.StoreId = create.StoreId;
o.SetBlob(new PullPaymentBlob()
{
Name = create.Name ?? string.Empty,

2
BTCPayServer/Models/StoreViewModels/GeneralSettingsViewModel.cs
View file

@ -54,7 +54,7 @@ namespace BTCPayServer.Models.StoreViewModels
public string DefaultCurrency { get; set; }
[Display(Name = "Minimum acceptable expiration time for BOLT11 for refunds")]
[Range(1, 365 * 10)]
[Range(0, 365 * 10)]
public long BOLT11Expiration { get; set; }
}
}

2
BTCPayServer/Models/StoreViewModels/PaymentViewModel.cs
View file

@ -26,7 +26,7 @@ namespace BTCPayServer.Models.StoreViewModels
public string DefaultCurrency { get; set; }
[Display(Name = "Minimum acceptable expiration time for BOLT11 for refunds")]
[Range(1, 365 * 10)]
[Range(0, 365 * 10)]
public long BOLT11Expiration { get; set; }
}
}

2
BTCPayServer/Models/WalletViewModels/PullPaymentsModel.cs
View file

@ -66,7 +66,7 @@ namespace BTCPayServer.Models.WalletViewModels
public IEnumerable<string> PaymentMethods { get; set; }
public IEnumerable<SelectListItem> PaymentMethodItems { get; set; }
[Display(Name = "Minimum acceptable expiration time for BOLT11 for refunds")]
[Range(1, 365 * 10)]
[Range(0, 365 * 10)]
public long BOLT11Expiration { get; set; } = 30;
[Display(Name = "Automatically approve claims")]
public bool AutoApproveClaims { get; set; } = false;