mirrors/btcpayserver
1
0
Fork 0
mirror of https://github.com/btcpayserver/btcpayserver.git synced 2025-02-21 14:04:12 +01:00
Code Issues Projects Releases Packages Wiki Activity

Improve error reporting in create invoice page (#3065)

Browse source
This commit is contained in:
Nicolas Dorier 2021-11-04 17:12:17 +09:00 • committed by GitHub
parent 51f0c2a5f8
commit d39ae86915
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
BTCPayServer/Controllers/InvoiceController.UI.cs
View file

@ -906,8 +906,11 @@ namespace BTCPayServer.Controllers
}
catch (BitpayHttpException ex)
{
Logs.PayServer.LogError(ex, $"Invoice creation failed due to invalid currency {model.Currency}");
ModelState.TryAddModelError(nameof(model.Currency), "Please make sure you entered a valid currency symbol, a rate provider is configured in store settings, and your configured rate provider is both online and providing rates for your selected currency.");
this.TempData.SetStatusMessageModel(new StatusMessageModel()
{
Severity = StatusMessageModel.StatusSeverity.Error,
Message = ex.Message
});
return View(model);
}
}

5
BTCPayServer/Controllers/InvoiceController.cs
View file

@ -409,6 +409,11 @@ namespace BTCPayServer.Controllers
return null;
}
}
else
{
var suffix = currentRateToCrypto?.EvaluatedRule is string s ? $" ({s})" : string.Empty;
logs.Write($"{logPrefix} This payment method should be created only if the amount of this invoice is in proper range. However, we are unable to fetch the rate of those limits. {suffix}", InvoiceEventData.EventSeverity.Warning);
}
}
#pragma warning disable CS0618

4
BTCPayServer/Views/Shared/_StatusMessage.cshtml
View file

@ -1,4 +1,4 @@
@{
@{
var parsedModel = TempData.GetStatusMessageModel();
}
@ -13,7 +13,7 @@
}
@if (!string.IsNullOrEmpty(parsedModel.Message))
{
@parsedModel.Message
<span style="white-space: pre-wrap;">@parsedModel.Message</span>
}
@if (!string.IsNullOrEmpty(parsedModel.Html))
{