mirrors/btcpayserver
1
0
Fork 0
mirror of https://github.com/btcpayserver/btcpayserver.git synced 2025-02-22 14:22:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Ensure the payjoin can generate a high R signature if the payer is sending it

Browse source
This commit is contained in:
nicolas.dorier 2020-05-25 06:47:43 +09:00
parent 77f6019d82
commit 9e9b5945fe
No known key found for this signature in database
GPG key ID: 6618763EF09186FE
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
BTCPayServer/Payments/PayJoin/PayJoinEndpointController.cs
View file

@ -25,6 +25,7 @@ using BTCPayServer.Data;
using NBitcoin.DataEncoders;
using Amazon.S3.Model;
using BTCPayServer.Logging;
using NBitcoin.Crypto;
namespace BTCPayServer.Payments.PayJoin
{
@ -234,7 +235,7 @@ namespace BTCPayServer.Payments.PayJoin
return BadRequest(CreatePayjoinError("invalid-transaction",
$"Provided transaction isn't mempool eligible {mempool.RPCCodeMessage}"));
}
var enforcedLowR = ctx.OriginalTransaction.Inputs.All(IsLowR);
var paymentMethodId = new PaymentMethodId(network.CryptoCode, PaymentTypes.BTCLike);
bool paidSomething = false;
Money due = null;
@ -472,7 +473,10 @@ namespace BTCPayServer.Payments.PayJoin
var coin = selectedUtxo.AsCoin(derivationSchemeSettings.AccountDerivation);
signedInput.UpdateFromCoin(coin);
var privateKey = accountKey.Derive(selectedUtxo.KeyPath).PrivateKey;
signedInput.Sign(privateKey);
signedInput.Sign(privateKey, new SigningOptions()
{
EnforceLowR = enforcedLowR
});
signedInput.FinalizeInput();
newTx.Inputs[signedInput.Index].WitScript = newPsbt.Inputs[(int)signedInput.Index].FinalScriptWitness;
}
@ -623,5 +627,12 @@ namespace BTCPayServer.Payments.PayJoin
}
return (Array.Empty<UTXO>(), PayjoinUtxoSelectionType.Unavailable);
}
private static bool IsLowR(TxIn txin)
{
IEnumerable<byte[]> pushes = txin.WitScript.PushCount > 0 ? txin.WitScript.Pushes :
txin.ScriptSig.IsPushOnly ? txin.ScriptSig.ToOps().Select(o => o.PushData) :
Array.Empty<byte[]>();
return pushes.Where(p => ECDSASignature.IsValidDER(p)).All(p => p.Length <= 71);
}
}
}