mirrors/btcpayserver
1
0
Fork 0
mirror of https://github.com/btcpayserver/btcpayserver.git synced 2025-03-13 03:16:46 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix: Plugin Exception Handler didn't disabled plugin if crash was detected

Browse source
This commit is contained in:
nicolas.dorier 2024-07-17 11:23:14 +09:00
parent b2480ad081
commit 209f84e67b
No known key found for this signature in database
GPG key ID: 6618763EF09186FE
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
BTCPayServer/Plugins/PluginExceptionHandler.cs
View file

@ -33,18 +33,19 @@ namespace BTCPayServer.Plugins
!PluginManager.IsExceptionByPlugin(exception, out var pluginName)) !PluginManager.IsExceptionByPlugin(exception, out var pluginName))
return ValueTask.FromResult(false); return ValueTask.FromResult(false);
_logs.Configuration.LogError(exception, $"Unhandled exception caused by plugin '{pluginName}', disabling it and restarting..."); _logs.Configuration.LogError(exception, $"Unhandled exception caused by plugin '{pluginName}', disabling it and restarting...");
PluginManager.DisablePlugin(_pluginDir, pluginName);
_ = Task.Delay(3000).ContinueWith((t) => _applicationLifetime.StopApplication()); _ = Task.Delay(3000).ContinueWith((t) => _applicationLifetime.StopApplication());
// Returning true here means we will see Error 500 error message. // Returning true here means we will see Error 500 error message.
// Returning false means that the user will see a stacktrace. // Returning false means that the user will see a stacktrace.
return ValueTask.FromResult(false); return ValueTask.FromResult(false);
} }
internal static bool GetDisablePluginIfCrash(HttpContext httpContext) public static bool GetDisablePluginIfCrash(HttpContext httpContext)
{ {
return httpContext.Items.TryGetValue("DisablePluginIfCrash", out object renderingDashboard) || return httpContext.Items.TryGetValue("DisablePluginIfCrash", out object renderingDashboard) ||
renderingDashboard is not true; renderingDashboard is not true;
} }
internal static void SetDisablePluginIfCrash(HttpContext httpContext) public static void SetDisablePluginIfCrash(HttpContext httpContext)
{ {
httpContext.Items.TryAdd("DisablePluginIfCrash", true); httpContext.Items.TryAdd("DisablePluginIfCrash", true);
} }