mirrors/btcpayserver
1
0
Fork 0
mirror of https://github.com/btcpayserver/btcpayserver.git synced 2024-11-20 02:28:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Caching of notifications, refactoring NotificationManager into singleton

Browse Source
This commit is contained in:
rockstardev 2020-06-12 00:01:45 -05:00
parent d1383d78c5
commit 0c170fc399
2 changed files with 46 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
BTCPayServer/HostedServices/NotificationDbSaver.cs
View File

@ -2,14 +2,13 @@
using System.Collections.Generic;
using System.Linq;
using System.Security.Claims;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using BTCPayServer.Data;
using BTCPayServer.Events;
using BTCPayServer.Events.Notifications;
using BTCPayServer.Models.NotificationViewModels;
using Microsoft.AspNetCore.Identity;
using Microsoft.Extensions.Caching.Memory;
namespace BTCPayServer.HostedServices
{
@ -47,51 +46,66 @@ namespace BTCPayServer.HostedServices
public class NotificationManager
{
private readonly ApplicationDbContext _db;
private readonly ApplicationDbContextFactory _factory;
private readonly UserManager<ApplicationUser> _userManager;
public NotificationManager(ApplicationDbContext db, UserManager<ApplicationUser> userManager)
public NotificationManager(ApplicationDbContextFactory factory, UserManager<ApplicationUser> userManager)
{
_db = db;
_factory = factory;
_userManager = userManager;
}
private static MemoryCache _cache = new MemoryCache(new MemoryCacheOptions());
private const int _cacheExpiryMs = 5000;
public NotificationSummaryViewModel GetSummaryNotifications(ClaimsPrincipal user)
{
var resp = new NotificationSummaryViewModel();
var userId = _userManager.GetUserId(user);
// TODO: Soft caching in order not to pound database too much
resp.UnseenCount = _db.Notifications
.Where(a => a.ApplicationUserId == userId && !a.Seen)
.Count();
if (_cache.TryGetValue<NotificationSummaryViewModel>(userId, out var obj))
return obj;
var resp = fetchNotificationsFromDb(userId);
_cache.Set(userId, resp, new MemoryCacheEntryOptions().SetAbsoluteExpiration(TimeSpan.FromMilliseconds(_cacheExpiryMs)));
if (resp.UnseenCount > 0)
return resp;
}
private NotificationSummaryViewModel fetchNotificationsFromDb(string userId)
{
var resp = new NotificationSummaryViewModel();
using (var _db = _factory.CreateContext())
{
try
{
resp.Last5 = _db.Notifications
.Where(a => a.ApplicationUserId == userId && !a.Seen)
.OrderByDescending(a => a.Created)
.Take(5)
.Select(a => a.ViewModel())
.ToList();
}
catch (System.IO.InvalidDataException iex)
{
// invalid notifications that are not pkuzipable, burn them all
var notif = _db.Notifications.Where(a => a.ApplicationUserId == userId);
_db.Notifications.RemoveRange(notif);
_db.SaveChanges();
resp.UnseenCount = _db.Notifications
.Where(a => a.ApplicationUserId == userId && !a.Seen)
.Count();
resp.UnseenCount = 0;
if (resp.UnseenCount > 0)
{
try
{
resp.Last5 = _db.Notifications
.Where(a => a.ApplicationUserId == userId && !a.Seen)
.OrderByDescending(a => a.Created)
.Take(5)
.Select(a => a.ViewModel())
.ToList();
}
catch (System.IO.InvalidDataException iex)
{
// invalid notifications that are not pkuzipable, burn them all
var notif = _db.Notifications.Where(a => a.ApplicationUserId == userId);
_db.Notifications.RemoveRange(notif);
_db.SaveChanges();
resp.UnseenCount = 0;
resp.Last5 = new List<NotificationViewModel>();
}
}
else
{
resp.Last5 = new List<NotificationViewModel>();
}
}
else
{
resp.Last5 = new List<NotificationViewModel>();
}
return resp;
}

2
BTCPayServer/Hosting/BTCPayServerServices.cs
View File

@ -202,7 +202,7 @@ namespace BTCPayServer.Hosting
services.AddSingleton<ChangellyClientProvider>();
services.AddSingleton<IHostedService, NotificationDbSaver>();
services.AddScoped<NotificationManager>();
services.AddSingleton<NotificationManager>();
services.AddScoped<NotificationSender>();
services.AddSingleton<IHostedService, NBXplorerWaiters>();