From 31fc72ec627a5ed39cd778fa28cd9012c9cf0c5b Mon Sep 17 00:00:00 2001 From: Elle Mouton Date: Tue, 1 Nov 2022 13:42:09 +0200 Subject: [PATCH 1/3] wire: increase max witness items per input --- wire/msgtx.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/wire/msgtx.go b/wire/msgtx.go index dbc379cf..8eeb0e9f 100644 --- a/wire/msgtx.go +++ b/wire/msgtx.go @@ -96,11 +96,13 @@ const ( // maxWitnessItemsPerInput is the maximum number of witness items to // be read for the witness data for a single TxIn. This number is - // derived using a possble lower bound for the encoding of a witness + // derived using a possible lower bound for the encoding of a witness // item: 1 byte for length + 1 byte for the witness item itself, or two // bytes. This value is then divided by the currently allowed maximum - // "cost" for a transaction. - maxWitnessItemsPerInput = 500000 + // "cost" for a transaction. We use this for an upper bound for the + // buffer and consensus makes sure that the weight of a transaction + // cannot be more than 4000000. + maxWitnessItemsPerInput = 4_000_000 // maxWitnessItemSize is the maximum allowed size for an item within // an input's witness data. This value is bounded by the largest From 5542131cc0441b6d1a52bb8a6818f275702a9da7 Mon Sep 17 00:00:00 2001 From: sputn1ck Date: Tue, 1 Nov 2022 13:19:56 +0100 Subject: [PATCH 2/3] build: remove linters This commit fixes the failing ci because of non-existant linters --- .github/workflows/go.yml | 12 ------------ goclean.sh | 19 ------------------- 2 files changed, 31 deletions(-) delete mode 100755 goclean.sh diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 8803194d..6a8317b8 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -14,19 +14,7 @@ jobs: go-version: ${{ matrix.go }} - name: Check out source uses: actions/checkout@v2 - - name: Install Linters - run: "curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.26.0" - name: Build env: GO111MODULE: "on" run: go build ./... - - name: Test - env: - GO111MODULE: "on" - run: | - sh ./goclean.sh - - - name: Send coverage - uses: shogo82148/actions-goveralls@v1 - with: - path-to-profile: profile.cov diff --git a/goclean.sh b/goclean.sh deleted file mode 100755 index dad9f8f1..00000000 --- a/goclean.sh +++ /dev/null @@ -1,19 +0,0 @@ -#!/bin/bash -# The script does automatic checking on a Go package and its sub-packages, including: -# 1. gofmt (http://golang.org/cmd/gofmt/) -# 3. go vet (http://golang.org/cmd/vet) -# 4. gosimple (https://github.com/dominikh/go-simple) -# 5. unconvert (https://github.com/mdempsky/unconvert) -# 6. race detector (http://blog.golang.org/race-detector) -# 7. test coverage (http://blog.golang.org/cover) - -set -ex - -env GORACE="halt_on_error=1" go test -race -tags="rpctest" -covermode atomic -coverprofile=profile.cov ./... - -# Automatic checks -golangci-lint run --deadline=10m --disable-all \ ---enable=gofmt \ ---enable=vet \ ---enable=gosimple \ ---enable=unconvert From 8eaf4c56983b912ee8be2add2b5fba2ab83af209 Mon Sep 17 00:00:00 2001 From: sputn1ck Date: Tue, 1 Nov 2022 13:07:28 +0100 Subject: [PATCH 3/3] build: bump version to v0.22.3 --- version.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/version.go b/version.go index e9a86b3b..30b6d7c9 100644 --- a/version.go +++ b/version.go @@ -18,7 +18,7 @@ const semanticAlphabet = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqr const ( appMajor uint = 0 appMinor uint = 22 - appPatch uint = 2 + appPatch uint = 3 // appPreRelease MUST only contain characters from semanticAlphabet // per the semantic versioning spec.