From c617c3536ad4312e15d150865c3af2bed6ef14b6 Mon Sep 17 00:00:00 2001
From: Ori Newman <orinewman1@gmail.com>
Date: Tue, 11 Feb 2020 09:57:18 +0200
Subject: [PATCH] remove redundant sending to msg.reply in processBlockMsg in
 blockHandler

---
 netsync/manager.go | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/netsync/manager.go b/netsync/manager.go
index 32715b8e..bb6dac92 100644
--- a/netsync/manager.go
+++ b/netsync/manager.go
@@ -1308,16 +1308,9 @@ out:
 			case processBlockMsg:
 				_, isOrphan, err := sm.chain.ProcessBlock(
 					msg.block, msg.flags)
-				if err != nil {
-					msg.reply <- processBlockResponse{
-						isOrphan: false,
-						err:      err,
-					}
-				}
-
 				msg.reply <- processBlockResponse{
 					isOrphan: isOrphan,
-					err:      nil,
+					err:      err,
 				}
 
 			case isCurrentMsg:
@@ -1539,7 +1532,7 @@ func (sm *SyncManager) SyncPeerID() int32 {
 // ProcessBlock makes use of ProcessBlock on an internal instance of a block
 // chain.
 func (sm *SyncManager) ProcessBlock(block *btcutil.Block, flags blockchain.BehaviorFlags) (bool, error) {
-	reply := make(chan processBlockResponse, 1)
+	reply := make(chan processBlockResponse)
 	sm.msgChan <- processBlockMsg{block: block, flags: flags, reply: reply}
 	response := <-reply
 	return response.isOrphan, response.err