mirrors/btcd
1
0
Fork 0
mirror of https://github.com/btcsuite/btcd.git synced 2025-02-23 06:35:20 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2233 from jharveyb/txid_string_check

Browse source 
wire: check TXID length before creating outpoint
This commit is contained in:
Olaoluwa Osuntokun 2024-08-15 16:03:51 -07:00 • committed by GitHub
commit 029e5a3cb5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
wire/msgtx.go
View file

@ -229,6 +229,11 @@ func NewOutPointFromString(outpoint string) (*OutPoint, error) {
if len(parts) != 2 { if len(parts) != 2 {
return nil, errors.New("outpoint should be of the form txid:index") return nil, errors.New("outpoint should be of the form txid:index")
} }
if len(parts[0]) != chainhash.MaxHashStringSize {
return nil, errors.New("outpoint txid should be 64 hex chars")
}
hash, err := chainhash.NewHashFromStr(parts[0]) hash, err := chainhash.NewHashFromStr(parts[0])
if err != nil { if err != nil {
return nil, err return nil, err

9
wire/msgtx_test.go
View file

@ -849,6 +849,15 @@ func TestTxOutPointFromString(t *testing.T) {
}, },
err: false, err: false,
}, },
{
name: "normal outpoint 2 with 31-byte txid",
input: "c7762a68ff164352bd31fd95fa875204e811c09acef40ba781787eb28e3b55:42",
result: &OutPoint{
Hash: hashFromStr("c7762a68ff164352bd31fd95fa875204e811c09acef40ba781787eb28e3b55"),
Index: 42,
},
err: true,
},
{ {
name: "bad string", name: "bad string",
input: "not_outpoint_not_outpoint_not_outpoint", input: "not_outpoint_not_outpoint_not_outpoint",