Commit Graph

3011 Commits

Author SHA1 Message Date
Andreas Schildbach
e5ec3a6a95 Transaction: Lower REFERENCE_DEFAULT_MIN_TX_FEE to 1000 and MIN_NONDUST_OUTPUT to 546.
These limits are still a thing these days both for relaying and mining transactions.
2018-02-22 20:27:44 +01:00
Andreas Schildbach
04f9de20d4 Use java.util.Arrays for cloning byte arrays. 2018-02-22 20:27:44 +01:00
Andreas Schildbach
0a54554413 ScriptChunkTest: Use Guava for concatenating byte arrays. 2018-02-22 20:10:05 +01:00
Andreas Schildbach
b455ebc635 Use Utils.uint*() and Utils.readUint*() methods for all remaining instances where we still did the bit stuffing manually. 2018-02-22 15:32:55 +01:00
Andreas Schildbach
aa593f46cd Utils: Reorder. 2018-02-22 12:32:52 +01:00
Andreas Schildbach
13828ce311 Utils: Add some missing documentation. 2018-02-22 12:29:38 +01:00
Andreas Schildbach
76c4f03d63 Utils: Rename uint64ToByteArrayLE() helper to int64ToByteArrayLE(), as the implementation is actually signed. 2018-02-22 12:21:59 +01:00
Andreas Schildbach
90636275af Utils: Remove unused and untested isLessThanUnsigned() and isLessThanOrEqualToUnsigned() helpers. 2018-02-22 11:53:49 +01:00
Andreas Schildbach
4daac38758 Utils: Inline getResourceAsString() into DeterministicKeyChainTest, as it's only being used there. 2018-02-22 11:43:26 +01:00
Andreas Schildbach
84048b565b Utils: Move parseAsHexOrBase58() to WalletTool, as it's only being used there. 2018-02-22 11:34:25 +01:00
Andreas Schildbach
e855030204 Utils: Move formatMessageForSigning() to ECKey, as it's only being used there. 2018-02-22 11:28:16 +01:00
Andreas Schildbach
96bdad5a67 Utils: Move copyOf() to UnsafeByteArrayOutputStream, as it's only being used there. 2018-02-22 11:08:58 +01:00
Andreas Schildbach
0fd8ab3fa2 Utils: Remove unused and untested appendByte() helper. 2018-02-22 10:54:45 +01:00
Andreas Schildbach
8295afc03b Utils: Remove reverseDwordBytes(), it wasn't used. 2018-02-22 10:47:07 +01:00
Andreas Schildbach
4300b2ee40 Replace use of Charset.forName() with Guava Charsets constants. 2018-02-22 10:37:10 +01:00
Andreas Schildbach
b50eddb0a2 Utils: Remove toString() and toBytes() helpers, use new String() and getBytes() with Guava charsets instead. 2018-02-22 10:21:14 +01:00
Andreas Schildbach
b6ecc380b8 Utils: Remove closeUnchecked() helpers, use Guava instead. 2018-02-22 10:09:30 +01:00
Andreas Schildbach
2b765d8aa8 Utils: Remove outdated comment. 2018-02-22 10:09:10 +01:00
Nicola Atzei
e42e6686cc ScriptChunk: Add method toByteArray(). 2018-02-21 23:35:05 +01:00
Andreas Schildbach
b87d22e2be Extract checked base58 encoding from Address to Base58. 2018-02-21 20:09:03 +01:00
Andreas Schildbach
eabc206b89 Base58Test: Independent methods for tests that expect an exception. 2018-02-21 19:48:05 +01:00
Andreas Schildbach
3ca4bd3792 Don't derive test classes from TestCase.
We have upgraded from JUnit 3 to JUnit 4 a while ago.
2018-02-21 19:41:46 +01:00
David Kingsbury
2acdb34948 MnemonicCode: Add null check for passphrase.
The null check is added due to a likely undesirable outcome when supplying a null passphrase.
If allowed, the salt will be "mnemonicnull", when one would expect only "mnemonic" due to the
following from BIP39 "If a passphrase is not present, an empty string "" is used instead."
2018-02-19 17:12:03 +01:00
Andreas Schildbach
c4d1f200a9 AddressTest: Fix cast. 2018-02-19 10:37:30 +01:00
harryge00
911f6d49c0 SendRequest example: Fix the print info. 2018-02-10 17:43:25 +01:00
Andreas Schildbach
9dd8e5ab92 WalletTool: New option --fee-sat-per-byte to set network fee in satoshi per byte. 2018-02-07 11:39:07 +01:00
HashEngineering
d3dca96a3c Allow watched keys to have account paths of an arbitrary length. 2018-02-07 11:32:43 +01:00
HashEngineering
be382c6800 Remove unnecessary accountPath parameter on watch key methods while preserving that the watched key account path can be arbitrary (does not have to be 0H). 2018-02-07 11:26:13 +01:00
Tomasz Ludek
4d0f15dc2e Wallet: Fix infinite recursion, causing StackOverflowError in deprecated version of Wallet.toString(boolean, boolean, boolean, AbstractBlockChain) method. 2018-02-05 20:04:45 +01:00
John L. Jegutanis
0ede3c7367 Script: Standard patterns are moved to a separate ScriptPattern class. 2018-02-05 19:55:07 +01:00
Andreas Schildbach
b6360e0858 CheckpointManagerTest: Fix name of test data directory. 2018-01-02 16:45:39 +01:00
Andreas Schildbach
3f2a8f11c5 Move some tests from ScriptTest to ScriptBuilderTest. 2018-01-02 16:41:11 +01:00
Nicola Atzei
3b80b707a5 ScriptBuilder: Add methods opTrue() and opFalse(). 2018-01-02 16:35:31 +01:00
Philip Whitehouse
e9469b3a72 Add test for CheckpointManager. 2018-01-01 13:52:02 +01:00
Nicola Atzei
6cc02d24b1 Script: Improve error reporting of CHECKSEQUENCEVERIFY. 2018-01-01 13:42:23 +01:00
Andreas Schildbach
c927f0238b Rename variable peers to peerGroup, as the name can be misleading. 2017-12-21 12:47:13 +01:00
Nelson MELINA
e036f8174a Allow to create wallets with an arbitrary account path. Adds a test for BIP44 wallets (account zero only).
Authors: Nelson MELINA <nelson.melina@mycelium.com>, Giuseppe Magnotta <giuseppe.magnotta@gmail.com>
2017-11-27 22:22:25 +01:00
Andreas Schildbach
61e5d714c3 Fix spelling in comments: heirarchy → hierarchy 2017-11-24 13:23:27 +01:00
Nicola Atzei
3cc652858c DumpedPrivateKey: Fix toBase58() for the case where the key is compressed. 2017-11-08 15:57:17 +01:00
Andreas Schildbach
6208f06d75 Add mainnet seed from OpenBazaar. 2017-11-03 10:43:59 +01:00
Nicola Atzei
9f5f973d8a ScriptBuilder: Fix minimal number encoding for -1. 2017-10-26 17:52:54 +02:00
Andreas Schildbach
383801bbb9 Wallet: Add JavaDoc link from autosaveToFile() to saveToFile(). 2017-09-13 11:59:12 +02:00
Andreas Schildbach
850f219607 Basic support for version 2 transactions.
Rather than considering all version 2 transactions risky, we now look more closely if any of its
inputs has a relative lock time. We can't check the relative locks though, because we usually
don't have the spent outputs (to know when they were creted).
2017-08-31 00:04:01 +02:00
Andreas Schildbach
3061734993 Move SEQUENCE_LOCKTIME_* flags from Transaction to TransactionInput. 2017-08-30 18:14:21 +02:00
Andreas Schildbach
9a3006d03c Transaction: Clarify the meaning of the transaction hash in the JavaDoc.
We will soon have multiple kinds of transaction hashes.
2017-08-25 13:06:26 +02:00
Andreas Schildbach
e32feb0aa9 Refresh bundled checkpoints. 2017-08-24 13:06:05 +02:00
Andreas Schildbach
738011a2a4 Peer: Drop Bitcoin Cash peers early, based on service bit 5.
They will fail the difficulty check anyway.
2017-08-22 12:27:07 +02:00
Andreas Schildbach
ff970f6fad VersionMessage: Define service bits a bit differently. 2017-08-22 12:18:56 +02:00
Andreas Schildbach
3ef5f9f2d7 ECKey.decodeFromDER(): Also throws IllegalArgumentException if unexpected class was read.
Fixes a regression that was introduced with commit e5f14e789a.
2017-08-22 12:03:28 +02:00
Andreas Schildbach
9c49fd5692 Peer: Demote logging of alert messages to debug. They're not important any more now that they're deprecated. 2017-08-14 16:07:18 +02:00