Commit graph

2799 commits

Author SHA1 Message Date
Andreas Schildbach
80cd521cc3 PeerGroup: Increase precision of download speed calculation by a bit. 2020-04-08 18:24:01 +02:00
Andreas Schildbach
1bfd5a5b60 Wallet: Demote log level of script cannot be parsed in markKeysAsUsed(). 2020-03-13 21:17:11 +01:00
Andreas Schildbach
67034e68aa Transaction: Fix missing newline in toString(). 2020-03-13 21:11:20 +01:00
Andreas Schildbach
8018cb2786 Transaction: In toString() print outputs of coinbase. 2020-03-13 21:10:40 +01:00
Andreas Schildbach
0b7bdff6de Script: Make a ScriptException message more elaborate. 2020-03-13 18:40:05 +01:00
John L. Jegutanis
c6a096678d Transaction: Make zero inputs/outputs transactions parsable.
Switch to the bitcoin core reference segwit parsing algorithm because
some no-segwit transactions with no inputs are incorrectly parsed as
segwit.

This change is to be 100% compatible with the reference implementation
and to be compatible with the PSBT implementation.
2020-03-13 09:44:41 +01:00
Craig Raw
bc46e8518d Transaction: Use VarInt not opcode for script length in hashForWitnessSignature(). 2020-03-08 22:43:56 +01:00
Andreas Schildbach
049c2f177d PeerGroup: Add a method for gracefully dropping all connected peers. 2020-03-08 00:20:01 +01:00
Andreas Schildbach
b86f3e70ae PeerGroup: Only drop peers after broadcast if the transaction has no broadcast confirmations.
Otherwise, peers might be continuously dropped when transactions are re-sent.
2020-03-08 00:20:01 +01:00
Andreas Schildbach
a4f241ef29 TransactionBroadcast: Don't complete the broadcast future early in the single peer case.
If you want to rely on the future it's better to drop peers after broadcast.
2020-03-08 00:20:01 +01:00
Andreas Schildbach
a867a80b76 TransactionBroadcast: Add a short delay before broadcast peers are dropped. 2020-03-08 00:19:07 +01:00
Andreas Schildbach
3bab49d4b1 PeerGroup: Introduce a priority for connecting and being picked as a download peer. 2020-03-05 10:24:33 +01:00
Andreas Schildbach
70559a3140 DnsDiscovery: Implement service bit filtering. 2020-03-05 01:14:06 +01:00
Andreas Schildbach
7d9f109ee1 Peer: Deprecate a redundant constructor. 2020-03-04 17:34:11 +01:00
Andreas Schildbach
57f53f038c Peer: Prevent connecting to remote peers if required services are not supported. 2020-03-04 17:34:11 +01:00
Andreas Schildbach
c967fda4d6 HttpDiscovery: Improve logging in getPeers(). 2020-03-04 15:53:45 +01:00
Andreas Schildbach
e8adb94a95 VersionMessage: In toString(), print services in textual form too. 2020-03-04 15:18:53 +01:00
Andreas Schildbach
b4bd43d428 VersionMessage: Move toStringServices() from Peer to here. 2020-03-04 15:14:03 +01:00
Andreas Schildbach
16fda8ffcb TestNet3Params: Add testnet.httpseed.bitcoin.schildbach.de HTTP seed. 2020-03-04 14:47:04 +01:00
Andreas Schildbach
06bd0a841e PeerDiscovery: Change getPeers() return type from array to list.
This gets rid of a lot of array/list conversions.
2020-03-04 12:35:02 +01:00
Andreas Schildbach
a165fb1834 MultiplexingDiscovery: Allow serially queried seeds, too. 2020-03-04 11:49:11 +01:00
Andreas Schildbach
4e41a51657 MultiplexingDiscovery: Make shuffling of queried peers optional. 2020-03-04 11:26:07 +01:00
Sean Gilligan
e4c6b98536 Make Guava an api dependency using java-library
Use the Gradle java-library plugin to make Guava an `api`
dependency since Guava types are used in the bitcoinj public API.

This allows us to remove explicit dependencies on
Guava in the other modules.
2020-02-29 15:28:09 -08:00
Sean Gilligan
5ade97b5b3 build.gradle: Make the 'core' submodule use the 'java-library' plugin, rather than 'java'. 2020-02-29 21:01:13 +01:00
Andreas Schildbach
65c1b8ca25 DefaultCoinSelector: Require only one broadcast confirmation when spending our own change.
This will improve the user experience when connected to only one peer (e.g. a trusted peer).
2020-02-28 15:59:37 +01:00
Andreas Schildbach
fb2d983b54 PeerGroup, TransactionBroadcast: Drop any peer a transaction has been broadcast to.
These peers will not send us back useful broadcast confirmations.
2020-02-28 15:59:37 +01:00
Andreas Schildbach
afb376fc07 MessageWriteTarget: Return a future from writeBytes() that completes when all bytes have been written to the OS network buffer. 2020-02-28 15:59:37 +01:00
Andreas Schildbach
0a085fde6d Peer: If a bloom filter is set on a peer that doesn't support filtering, disconnect. 2020-02-27 23:32:50 +01:00
Andreas Schildbach
95e08ef86c PeerGroup: Require SegWit protocol and service when selecting a download peer.
Those nodes are extremely common now.
2020-02-27 23:32:50 +01:00
Andreas Schildbach
8d983649d3 PeerGroup: Don't immediately select a download peer in startBlockChainDownload(). Wait for enough peers to be connected. 2020-02-27 23:13:26 +01:00
Andreas Schildbach
98f8c42140 TestWithPeerGroup: Time out this group of tests after 10 seconds. 2020-02-27 23:11:28 +01:00
John L. Jegutanis
1991d8a882 MessageSerializer: Move protocolVersion from Message to here.
This change moves protocolVersion from Message to MessageSerializer.
The main reason is to support parsing transactions as non-segwit.
This is impossible to do otherwise, as MessageSerializer#makeTransaction()
does not accept a protocolVersion parameter.
Additionally this change makes the MessageSerializer similar to the
Stream in Bitcoin Core, where the protocol version can be modified.
2020-02-16 18:03:10 +01:00
Andreas Schildbach
3cbb10334e BitcoinSerializer: Add equals() and hashCode(). 2020-02-16 17:37:44 +01:00
Andreas Schildbach
73583776a6 ChildMessage: Fix a missing @Nullable in constructor argument. 2020-02-16 17:13:09 +01:00
John L. Jegutanis
d734d8854a Utils: Introduce Utils.resetMocking() and use it from AbstractFullPrunedBlockChainTest.
It appears that the tests do not run in the same order or the static variables
are not reset between runs on all systems or Gradle versions.
So it happened that the test UtilsTest.testRollMockClock() was messing up
the time for the H2FullPrunedBlockChainTest (and the LevelDB one), failing tests.
2020-01-30 17:02:30 +01:00
Andreas Schildbach
f258cbc122 Update JUnit to 4.13. 2020-01-23 01:20:44 +01:00
Andreas Schildbach
0112e3ccbe Update slf4j to 1.7.30. 2020-01-23 01:16:58 +01:00
Andreas Schildbach
0473c748b9 Update OkHttp to 3.12.8. 2020-01-23 01:14:21 +01:00
Andreas Schildbach
68538e57af Update Guava to 28.2-android. 2020-01-23 01:09:35 +01:00
Anton Kumaigorodski
163d39dbff MainNetParams: Add lightning-wallet.com HTTP seed. 2020-01-12 17:23:56 +01:00
Andreas Schildbach
66403d1946 PeerGroup.ChainDownloadSpeedCalculator: Log chain height with end of sync. 2019-12-14 17:11:11 +01:00
Andreas Schildbach
80228d7954 PeerGroup: Only select a download peer if more than maxConnections/2 peers are connected. 2019-12-08 13:02:31 +01:00
Andreas Schildbach
c2e1383b58 PeerGroup: Be more careful about selecting download peer.
We now select a (new) download peer only if there is a clear consensus about a common chain height between
connected peers. If there is a tie between two common heights, we stay safe and don't change anything.
2019-12-08 13:02:31 +01:00
Andreas Schildbach
924e525d52 PeerGroup: Move maxOfMostFreq() from Utils to here, as here is the only usage. 2019-12-08 11:11:01 +01:00
Andreas Schildbach
76071d8378 DatabaseFullPrunedBlockStore implementations: Make sure SegWit addresses fit into the openoutputs.toaddress column. 2019-11-29 11:43:26 +01:00
Andreas Schildbach
141e4024e6 Replace remaining System.currentTimeMillis() by the Utils equivalent.
This is important for using the mock clock in tests.
2019-11-26 17:58:45 +01:00
Andreas Schildbach
8b55b8c0a7 Make a couple of tests use the mock clock to improve test reproducibility. 2019-11-26 17:46:31 +01:00
Andreas Schildbach
d8cd74dbb3 Utils: Make mockTime field private.
Use the various setters.
2019-11-26 17:01:43 +01:00
Andreas Schildbach
af9400a650 PeerFilterProvider: Remove isRequiringUpdateAllBloomFilter().
Bloom filters will now always be created with UPDATE_ALL. With SegWit there is hardly any wallet
that can do without. This will save some locking.
2019-11-26 16:42:00 +01:00
Andreas Schildbach
c14e9240ad PeerFilterProvider: Rework JavaDoc. 2019-11-26 16:40:17 +01:00