Commit Graph

3977 Commits

Author SHA1 Message Date
Sean Gilligan
5db6a8fab5 LegacyAddressTest: remove an unused import 2024-08-31 12:03:59 +02:00
Sean Gilligan
45c5abdebd LegacyAddressTest: use MockAltNetwork directly
This simplifies the test, removes a dependency on o.b.core.NetworkParameters,
and also demonstrates using an Alt Network using only `base` classes.
2024-08-30 20:16:21 +02:00
Sean Gilligan
ed62faea8b MockAltNetwork: move to o.b.base.internal 2024-08-30 20:14:29 +02:00
Sean Gilligan
1903f6bc2f LegacyAddressTest: use BitcoinNetwork.legacyP2SHHeader() rather than NetworkParameters
This adds some validation of `BitcoinNetwork.legacyP2SHHeader()` and
removes a dependency on `core`.
2024-08-30 18:44:06 +02:00
Sean Gilligan
e2c6d2505b LegacyAddress: again, don't link to classes outside base in JavaDoc
Use `@code` rather than `@link` in these cases.
2024-08-30 18:37:15 +02:00
Andreas Schildbach
362f2d5f93 base: extinguish unwanted references from main classpath
It removes references to core and crypto modules, as well as to Guava.
2024-08-30 10:20:09 +02:00
Andreas Schildbach
eef3f8f8d9 SegwitAddress, LegacyAddress, package-info.java: don't link to classes outside base in JavaDoc
Use `@code` rather than `@link` in these cases.
2024-08-30 00:54:57 +02:00
Andreas Schildbach
3a45d13895 LegacyAddress: prefer a reference to BitcoinNetwork over NetworkParameters 2024-08-30 00:40:15 +02:00
Sean Gilligan
0080f79a05 base: remove all (deprecated) usage of Networks.get()
Remove `DefaultAddressParserProvder.fromNetworks()` and everything that
depends on it. All methods being removed were previously deprecated.

Removing `DefaultAddressParserProvder.fromNetworks()` propagates to the
3 AddressParser getLegacy() methods and several other deprecated methods
in Address, LegacyAddress, and Segwit Address.

This change means that nothing in `o.b.base` will use the global list of
supported networks stored in `Networks`. This is a mechanism we previously
added to support other Bitcoin-compatible networks and their addressing
schemes (e.g. LiteCoin.) "Alt networks" are still supported, but
applications using them will need to create their own implementations
of AddressParser to do it. We hope to eventually entirely remove the global
state returned by Networks.get(), but this PR is just about removing
its usage from `o.b.base`.

Note: this also removes all uses of javax.annotation.Nullable from
o.b.base. There are still instances of @NonNull which we should
probably leave in until we move to JSpecify.
2024-08-29 23:33:26 +02:00
Andreas Schildbach
c967c6045c build.gradle: remove sourceCompatibility, targetCompatibility
We have defined `release` one way or another, and on JDK 17 that should
suffice.
2024-08-29 23:07:30 +02:00
Andreas Schildbach
34c1e4b708 build.gradle: use tasks.withType() to apply options to tests as well 2024-08-29 22:56:59 +02:00
Andreas Schildbach
a2642d8af7 prepare 0.18-SNAPSHOT 2024-08-23 16:46:19 +02:00
Andreas Schildbach
ba60554425 optimize imports 2024-08-21 13:32:13 +02:00
Andreas Schildbach
e51f1630df build.gradle: update Guava to 33.3.0-android 2024-08-21 13:12:59 +02:00
Sean Gilligan
58ca59ba53 TorUtils: move to o.b.core.internal
It is only used by PeerAddress, so it makes sense for it to be in the
same package as PeerAddress. This removes a Guava dependency from
the o.b.crypto package/module.
2024-08-19 20:14:07 +02:00
Sean Gilligan
3ded6f9c66 ECKey, BtcFormat: fix bad JavaDoc @link tags
JDK 23 fixes a bug that allowed these invalid links:
https://bugs.openjdk.org/browse/JDK-8164094

This PR fixes the invalid links and does not require JDK 23, but
does fix our build so it will work with JDK 23.
2024-08-15 08:39:03 +02:00
Sean Gilligan
d394ce63a5 DefaultAddressParserProvider: deprecate fromNetworks()
It was already package-private and is only used by deprecated methods
in `AddressParser`.
2024-08-06 00:41:27 +02:00
Andreas Schildbach
33a69dcebe build.gradle: update Hamcrest to 3.0 2024-08-03 10:16:36 +02:00
Andreas Schildbach
5231112ffa build.gradle: update Jackson to 2.17.2 2024-08-03 10:16:36 +02:00
Andreas Schildbach
d56f51ad3b build.gradle: update EasyMock to 5.4.0 2024-08-03 10:16:36 +02:00
Andreas Schildbach
eb8b415d99 build.gradle: update SLF4J to 2.0.13 2024-08-03 10:16:36 +02:00
Andreas Schildbach
32c05aeb8d build.gradle: update protobuf-javalite to 4.27.3 2024-08-03 09:37:46 +02:00
Andreas Schildbach
20ac61ea23 build.gradle: update Guava to 33.2.1-android 2024-08-03 09:34:29 +02:00
Andreas Schildbach
0c1828a302 Prepare 0.17-SNAPSHOT 2024-08-02 12:55:08 +02:00
Andreas Schildbach
739ff511de Tag 0.17-alpha5 2024-08-02 10:06:41 +02:00
Andreas Schildbach
6a2e01bfed checkpoints.txt: refresh bundled checkpoints 2024-08-02 10:04:15 +02:00
Andreas Schildbach
fcb36eb06b SPVBlockStore: support 32 byte chain work
Existing V1 files are automatically migrated to V2 format.

Includes a test for migration from V1 to V2 format. This requires
`getRingCursor()` to be changed from private to package-private.
2024-08-01 17:20:36 +02:00
Andreas Schildbach
effe62b649 SPVBlockStore: don't pass buffer into setRingCursor(), getRingCursor()
It's available as a field already.
2024-07-25 21:24:02 +02:00
Andreas Schildbach
16388844ab SPVBlockStore: rewind buffer directly before accesses to magic header
This is meant to make sure the buffer position is always right.
2024-07-15 08:13:43 +02:00
Andreas Schildbach
b3d7c6aae3 SPVBlockStore: compare magic header as bytes, not string
This gets rid of several bytes to/from string conversions.
2024-07-14 22:57:20 +02:00
Andreas Schildbach
77de8684e9 SPVBlockStore: deprecate constant HEADER_MAGIC
It's an implementation detail. We should be switching this to private in future.
2024-07-12 12:59:41 +02:00
Andreas Schildbach
147e479e63 SPVBlockStore: lock the store file as early as possible 2024-07-12 12:17:53 +02:00
Andreas Schildbach
ce126353a2 BuildCheckpoints: create mixed-format checkpoints
Create checkpoints with 12 (or less) bytes of work in the old V1 format,
otherwise V2. This will make checkpoint files easier to review.

This un-deprecates the V1 format in StoredBlock, since it's no longer
planned to remove that in the forseeable future.

This also reverts recent changes to the bundled checkpoints
(commit de8afc67ca).
2024-07-01 15:53:03 +02:00
Andreas Schildbach
de8afc67ca CheckpointManager, BuildCheckpoints: support checkpoints with 32 byte chain work
* `BuildCheckpoints` now always creates checkpoints with 32 byte chain work
* `CheckpointManager` knows how to read both 12 and 32 byte chain work

Also updates the bundled checkpoints to the new format and a test.
2024-06-28 18:50:45 +02:00
Andreas Schildbach
db329beca5 CheckpointManager, BuildCheckpoints: remove support for binary checkpoint format
Use the textual format instead.
2024-06-27 21:21:45 +02:00
Andreas Schildbach
f5c36e1a80 checkpoints.txt: refresh bundled checkpoints 2024-06-27 20:41:27 +02:00
Andreas Schildbach
a1257ce83d StoredBlock: add serializeCompactV2(), deserializeCompactV2()
The old format will soon run out of bytes for the chain work value.

Also deprecates the old methods and adds tests for the V2 format.
2024-06-27 18:23:29 +02:00
Andreas Schildbach
39f409f351 StoredBlock: rework comment about usage of serializeCompact(), deserializeCompact()
The explicit list of usages was already stale. Rather, just mention
it's being used internally.
2024-06-27 09:05:38 +02:00
Andreas Schildbach
a05fc05e56 StoredBlockTest: add tests for serializeCompact(), deserializeCompact(), moreWorkThan() 2024-06-27 08:59:28 +02:00
Andreas Schildbach
009f19abc1 StoredBlock: remove an outdated comment
We don't have unsafeBitcoinSerialize() any more.
2024-06-26 23:32:47 +02:00
Sean Gilligan
32e9145722 StoredBlock: update comment about CHAIN_WORK_BYTES
The original comment, written in 2011 said "12 bytes should be plenty for now".
As of June 2024, we know that 12 bytes is not enough.
2024-06-24 19:14:38 +02:00
Sean Gilligan
0aa17cd0a2 ByteUtils: improve JavaDoc comments for bigIntegerToBytes(), bytesToBigInteger() 2024-06-24 19:11:16 +02:00
Sean Gilligan
fae543bb6d StoredBlock: use ByteUtils.bigIntegerToBytes to convert chainWork
This is a fix for Issue #3410 that will allow main net blocks above
849,137 to be processed. As of block 849,138 we can no longer fit
total chainwork in a 12-byte *signed* field. This fix "kicks the can
down the road" by making the field 12-bytes *unsigned*.

We should open a new issue to address the long term need for bigger
values. Note that converting the field to 12-byte unsigned precludes
us from using the most-significant bit as a flag for a new format, but
we should be able to pick some arbitrary value, say 0xA0 as a version
flag and declare that values less than 0xA0 are "unversioned".
2024-06-23 18:49:54 -04:00
Andreas Schildbach
d265ea0aa8 ECKey: remove mention of mailing list in documentation 2024-06-01 23:58:11 +02:00
Andreas Schildbach
6feeb5a1c0 TransactionConfidence: rename getLastBroadcastTime() method from lastBroadcastTime()
This effectively reverts commit c2cabead9a.
2024-05-14 17:51:00 +02:00
Andreas Schildbach
ff42c49648 PeerGroup: rename getFastCatchupTime() method from fastCatchupTime()
This effectively reverts commit 45f87d8339.
2024-05-14 17:51:00 +02:00
Andreas Schildbach
781d64550b Script: rename getCreationTime() method from creationTime()
This effectively reverts commit b309308076.
2024-05-14 17:51:00 +02:00
Oliver Aemmer
70fb77d2d1 wallet.proto: rename to Key.Type.ENCRYPTED from ENCRYPTED_SCRYPT_AES 2024-05-05 14:24:59 +02:00
Andreas Schildbach
92c2c29508 Prepare 0.17-SNAPSHOT 2024-04-29 20:13:45 +02:00
Andreas Schildbach
e42c59b818 Tag 0.17-alpha4 2024-04-29 20:12:26 +02:00