Sean Gilligan
49290a8ce0
ForwardingService: rename coinForwardingListener
from coinsReceivedListener
2023-03-27 21:43:59 +02:00
Sean Gilligan
a0c5501b4b
ForwardingService: improve JavaDoc
2023-03-27 21:35:04 +02:00
Sean Gilligan
7cd8f80e44
ForwardingService: fix usage message
2023-03-27 21:32:24 +02:00
Andreas Schildbach
c38ec69246
BriefLogFormatter: provide init(Level)
to use a custom log level
2023-03-27 21:02:59 +02:00
Sean Gilligan
3b6bdbad02
WalletAppKit: add launch()
methods, simplify examples
2023-03-27 20:59:58 +02:00
Sean Gilligan
41ed5a984b
Wallet: deprecate public fields in SendResult
, replace with accessors
...
* Deprecate public fields in `SendResult`
* Make available equivalent accessors
* Update all usages
This prepares the way for replacing `SendResult` with `TransactionBroadcast`
in the future.
2023-03-27 20:22:35 +02:00
Sean Gilligan
774fde99fb
Wallet: move methods sendTransaction()
and waitForConfirmation()
from ForwardingService
...
`waitForConfirmation()` now has two variants for convenience.
2023-03-27 19:30:27 +02:00
Sean Gilligan
b24964d056
TransactionBroadcast: add awaitRelayed()
, deprecate future()
...
* Add `awaitRelayed()` method that returns a CF that completes when relaying is confirmed.
* Deprecate `future()` and reimplement it using `awaitRelayed()`.
2023-03-27 18:38:15 +02:00
Andreas Schildbach
504b67c186
ByteUtils: check range of values supplied to write helpers for the Java Unsigned Integer API
...
These checks uncovered various uses of illegal values (now fixed).
They should help this won't happen in future.
2023-03-27 17:53:26 +02:00
Sean Gilligan
2aa764d403
VarInt: simplify encode()
2023-03-27 17:38:58 +02:00
Andreas Schildbach
3746516859
VarInt: use constants for possible sizes
2023-03-27 16:54:00 +02:00
Andreas Schildbach
140912b080
VarIntTest: add test for reading and writing
2023-03-27 16:49:21 +02:00
Andreas Schildbach
21fae58bc8
VarInt: implement toString()
2023-03-27 16:48:47 +02:00
Andreas Schildbach
301c8e4a76
VarInt: implement equals()
and hashCode()
...
`originallyEncodedSize` is not considered on purpose, because it is only
relevant for serialization.
2023-03-27 16:26:16 +02:00
Andreas Schildbach
2faaf9febc
VarInt: direct use of ByteBuffer
for reading and writing
2023-03-27 16:00:37 +02:00
Sean Gilligan
b4abf7d794
VarInt: get rid of code duplication in deprecated constructor
2023-03-27 15:50:13 +02:00
Andreas Schildbach
b528fb5180
build.gradle: update SLF4J to 2.0.7
...
Starting with SLF4J 2.0.0, we can use the fluent logger API.
2023-03-27 15:25:02 +02:00
Sean Gilligan
2e3e6d4485
TransactionBroadcast: add awaitSent()
method
...
This just returns the used internally (and therefore tested) `sentFuture`.
2023-03-27 12:28:27 +02:00
Sean Gilligan
bce7b11038
Script: downsize MAX_SCRIPT_ELEMENT_SIZE
to int
from long
...
* The value is 520
* Java collection sizes are `int`
* All usages are as `int`
2023-03-27 09:54:42 +02:00
Sean Gilligan
ee74f34dcc
FullBlockTestGenerator: use writeInt64LE()
for writing a 64-bit integer
...
Previously two `writeInt32LE()` and a right-shift on an `int` by 32 were used.
2023-03-27 09:48:01 +02:00
Sean Gilligan
37a06b150f
Transaction: replace Guava Lists.reversed()
with JDK equivalent
2023-03-27 09:38:38 +02:00
Andreas Schildbach
c5faecf3b6
SegwitAddress: flip arguments of new static constructor fromBech32()
...
Otherwise the deprecation cycle won't be of much use for consumers who pass `null` for `params`.
2023-03-27 09:23:04 +02:00
Andreas Schildbach
150c911750
LegacyAddress: flip arguments of new static constructor fromBase58()
...
Otherwise the deprecation cycle won't be of much use for consumers who pass `null` for `params`.
2023-03-27 09:17:37 +02:00
Andreas Schildbach
4bdb0f85e4
BitcoinURI: flip arguments of new constructor
...
Otherwise the deprecation cycle won't be of much use for consumers who pass `null` for `params`.
2023-03-27 09:14:11 +02:00
Sean Gilligan
b13fe5a5d2
ForwardingService: make coinsReceivedListener()
use wallet
parameter
...
...instead of `kit.wallet()`.
2023-03-27 09:11:17 +02:00
Sean Gilligan
3ad07ea28c
ForwardingService: rename forwardingCoinSelector()
parameter
...
...to `parentTxId` (which is more clear and correct)
2023-03-27 09:08:27 +02:00
Sean Gilligan
884072c9e3
WalletAppKit: make Closeable
2023-03-26 19:40:28 +02:00
Sean Gilligan
84c8a2887a
ForwardingService: make Closable
not AutoCloseable
...
`Closeable` implements `AutoCloseable` but narrows the exception thrown
from `Exception` to `IOException`. ForwardingService.close() currently
doesn't throw any exceptions.
2023-03-26 19:37:08 +02:00
Andreas Schildbach
c10cf7ccbe
Sha256Hash: direct use of ByteBuffer
in hashCode()
...
A hash code is just an arbitrary number. It doesn't care about signedness and endianess.
2023-03-26 19:07:22 +02:00
Andreas Schildbach
d478eb2a55
Network: migrate legacyAddressHeader()
and legacyP2SHHeader()
from NetworkParameters
2023-03-26 18:59:51 +02:00
Andreas Schildbach
ba72884832
Transaction: add back a byte[]
-based constructor as deprecated
2023-03-26 18:53:06 +02:00
Sean Gilligan
c05fefe8f8
MarriedKeyChain: simplify Builder.followingKeys()
...
* Add `followingKey()` method that takes a single key
* Deprecate unused `followingKeys(DeterministicKey, DeterministicKey...)`
* Replace usage of Guava's `Lists.asList()`
2023-03-26 18:49:32 +02:00
Sean Gilligan
6e1fc2cda9
WalletTool: rename tx
from t
in send()
2023-03-26 18:15:54 +02:00
Sean Gilligan
17f9b1dcfe
WalletTool: don't unnecessarily reinitialize tx variable t
in send()
2023-03-26 18:13:43 +02:00
Sean Gilligan
f58d07a623
ForwardingService: start()
returns receiving address
2023-03-26 18:10:09 +02:00
Sean Gilligan
3e1855b201
SendRequest: make field tx
immutable
2023-03-26 18:03:56 +02:00
Andreas Schildbach
4bdb8d7836
CheckpointManager: fix wrong unit of time
...
This mistake was introduced in commit 838b12c046
.
The original line before the `java.time` migration was:
`60 * 60 * 24 * 7; // one week in seconds`
2023-03-26 17:58:10 +02:00
Sean Gilligan
795da8f54b
Wallet: replace Guava newArrayList()
with singletonList()
2023-03-26 11:16:09 +02:00
Sean Gilligan
b7cf58ba6d
GuiUtils: replace Guava Throwables.getRootCause()
with private helper method
...
Private helper walks up the chain and avoids loops.
2023-03-26 01:50:02 +01:00
Sean Gilligan
66d96ab29d
WalletPasswordController: remove use of Guava Longs
...
Use ByteBuffer in private methods for long to byte[] conversion.
2023-03-26 01:47:03 +01:00
Sean Gilligan
8566819ff2
SendMoneyController: use CompletableFuture
not Guava
...
This is the last remaining use of Guava futures in
WalletTemplate.
2023-03-26 01:35:34 +01:00
Andreas Schildbach
7302a24962
.gitlab-ci.yml: create job artifacts
2023-03-26 00:28:11 +01:00
Andreas Schildbach
1753bc4ea7
.gitlab-ci.yml: print build environment at end of log
2023-03-25 21:03:43 +01:00
Andreas Schildbach
26e5500ae8
.gitlab-ci.yml: append JDK to job names
2023-03-25 21:01:00 +01:00
Andreas Schildbach
b585f9f08e
KeyChainGroupTest: reduce false positive rate for the bloom filters
...
This will hopefully reduce spurious test failures.
2023-03-25 13:29:20 +01:00
Andreas Schildbach
3bbbf40fa4
Message: add back deprecated method unsafeBitcoinSerialize()
2023-03-25 13:19:59 +01:00
Andreas Schildbach
c581dfb791
ByteUtils: rework JavaDoc of all writeInt*()
helpers
2023-03-24 19:35:52 +01:00
Andreas Schildbach
47a5d73035
ByteUtils: rename all writeUInt*()
helpers to writeInt*()
...
This creates overloads in some cases.
2023-03-24 19:34:06 +01:00
Sean Gilligan
f3c4b5fcf4
BloomFilter: use signed integer for the nonce (nTweak)
...
It's arbitrary data and we're not supposed to do math on it, so it's
safe to use a signed Java `int`.
Also use `new Random().nextInt()` to generate the nonce. We were
previously generating a random double, multiplying by `Long.MAX_VALUE`
and then truncating the low 32-bits of the long. Using `.nextInt()`
might actually generate MORE randomness since there will be no truncation.
2023-03-24 18:34:09 +01:00
Andreas Schildbach
b39ad1904d
Message: remove check against max message size in checkReadLength()
...
Checking against the remaining bytes in the payload should be enough.
The payload can't be longer than max message size.
2023-03-24 16:15:21 +01:00