mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-10 17:26:28 +01:00
Code Issues Projects Releases Packages Wiki Activity
4948 commits 15 branches 59 tags 53 MiB
Commit graph

3922 commits

Author SHA1 Message Date
Sean Gilligan
576adf229b PBKDF2SHA512: remove redundant Mac.reset() calls 
Calls to `Mac.reset()` are not needed after `Mac.doFinal(input)`.
 2023-09-25 15:21:13 +02:00
Sean Gilligan
3023188541 PBKDF2SHA512: simplify F() by using ByteUtils.concat() 2023-09-25 15:14:07 +02:00
Sean Gilligan
053cd60dc5 PBKDF2SHA512: chain methods in INT() 
Simplify slightly by using a more functional-style approach.
 2023-09-25 15:11:15 +02:00
Sean Gilligan
e67401d7a5 PBKDF2SHA512: add JavaDoc comment to derive() method 2023-09-25 15:08:00 +02:00
Andreas Schildbach
0d57e1ece1 MnemonicCode: fix comment about iteration count 2023-09-25 15:04:17 +02:00
Sean Gilligan
56658e44de build.gradle: normalize file/directory permissions within JARs 
This aims to make our build reprodicible.
 2023-09-19 14:00:38 +02:00
Andreas Schildbach
f41b495610 build.gradle: strip timestamps from JavaDoc HTMLs 
This aims to make our build reprodicible.
 2023-09-16 22:09:51 +02:00
Andreas Schildbach
7605fa9535 build.gradle: strip timestamps from JARs 
This aims to make our build reprodicible.
 2023-09-16 22:08:45 +02:00
Sean Gilligan
81b78292e2 PeerGroup, FilterMerger: deprecate setting false-positive rate 
In the bitcoinj code itself, the false-positive rate is never changed
after constructing a `PeerGroup` or a `FilterMerger`.

* Deprecate methods for setting Bloom Filter FP rate in both methods
* Add constructor params to `PeerGroup` so they can be set at construction
  time, if non-default values are needed
 2023-09-16 11:42:24 +02:00
Sean Gilligan
5955eee4c8 Wallet: replace Interables.concat() with Stream.concat() in getWatchedOutputs() 
This simplifies the code and removes a Guava dependency.
 2023-09-16 11:31:32 +02:00
Sean Gilligan
68e61d9507 Wallet: refactor getWatchedOutputs() to use streams 
1. Get a spliterator from the concatenated iterator
2. Use streams instead of nested loops
3. Extract `isWatchedScriptPubKey()` helper function
 2023-09-16 11:28:56 +02:00
Sean Gilligan
bce4475aaf replace Guava Bytes.concat() with own ByteUtils.concat() 2023-09-16 11:22:11 +02:00
Sean Gilligan
daa4da8d9f remove use of Guava @VisibleForTesting on all package-private members 
From now on we will only use this annotation on `public` or `protected` members.
 2023-09-16 11:13:22 +02:00
Sean Gilligan
57b3649e55 PBKDF2SHA512: replace unneeded check for max dkLen with comment 
Since the check for `dkLen > (2^32 - 1) * H_LEN` is effectively a no-op,
replace it with a comment.
 2023-09-16 09:07:50 +02:00
Sean Gilligan
b4f7deaba5 PBKDF2SHA512: calculate l with integer math 2023-09-14 22:46:25 +02:00
Sean Gilligan
5a11957eb3 PBKDF2SHA512: declare/catch specific exceptions 
Make it more clear which exceptions are thrown by `F` and caught by
the `try` in `derive()`.
 2023-09-14 22:39:58 +02:00
Sean Gilligan
ee23c2d6ff PBKDF2SHA512: don't allow negative count or dkLen 2023-09-14 22:37:09 +02:00
Sean Gilligan
140deb0669 PBKDF2SHA512: move dkLen check out of try/catch 
It throws an exception so doesn't need an if/else
and it also doesn't need to be in the try.
 2023-09-14 22:34:12 +02:00
Sean Gilligan
4e039df446 PBKDF2SHA512: make hLen a constant 2023-09-14 18:25:31 +02:00
Sean Gilligan
c830107bce PBKDF2SHA512: set hLen to correct value of 64 
This is a bugfix to the API, but since `MnemonicCode` always
passes `dkLen` of 64 and the `System.arraycopy()` on line 66 truncates
`baos.toByteArray()` to `dkLen` length, the call to `derive()` works
correctly for our use-case.
 2023-09-14 18:21:53 +02:00
Andreas Schildbach
4b987cb172 PBKDF2SHA512: remove comment about SHA-1 test vectors 
They won't pass against our SHA-512 based code, and we have
our tests now.
 2023-09-14 17:07:23 +02:00
Andreas Schildbach
040e2f4b3e PBKDF2SHA512Test: tests for PBKDF2SHA512.derive() 2023-09-14 08:17:53 +02:00
Sean Gilligan
b90af12aea PBKDF2SHA512: update URLs in JavaDoc 
The IETF `https:` URLs are what the previous `http:` URLs redirect to.
The Cryptofreak URL is the same but with `https:`.
 2023-09-12 22:18:19 +02:00
Sean Gilligan
f7d2b38aae PBKDF2SHA512: properly format JavaDoc 2023-09-12 22:16:48 +02:00
Sean Gilligan
7af3124f65 FilteringCoinSelector: use stream in select() 
Note: this also prevents mutation of the candidate list which isn't
a problem as used within bitcoinj, but could be a problem if used
externally.
 2023-09-12 19:01:41 +02:00
Sean Gilligan
0597c3383f CoinSelector: mark as functional interface 
The `@FunctionalInterface` annotation doesn't change behavior of `CoinSelector`
in any way. It just declares our intention that it be used as a functional
interface and will generate compiler errors if someone changes the code so that
it is no longer a SAM type.
 2023-09-12 18:46:18 +02:00
Sean Gilligan
bd52545fb7 DefaultCoinSelector: use List.sort() instead of Collections.sort() 2023-09-12 18:36:24 +02:00
Sean Gilligan
2be7ee33f8 DefaultCoinSelector: extract compareByDepth() comparator 2023-09-12 18:34:24 +02:00
Sean Gilligan
9eaff37897 FilteringCoinSelector: make immutable 
This is an API-breaking change because it requires a list of
`TransactionOutPoint` to be passed to the constructor and remove the
`excludesOutputsSpentBy(tx)` method.

`Wallet` is updated to use the new constructor.
 2023-09-12 18:30:30 +02:00
Sean Gilligan
82feb7b831 CoinSelection: add defensive copy in constructor 2023-09-12 18:22:34 +02:00
Sean Gilligan
e8491bbd88 KeyTimeCoinSelector: use a stream in select() 
Note that this removes the warning about exceeding the limit.
 2023-09-12 18:19:14 +02:00
Sean Gilligan
339e0d0450 KeyTimeCoinSelector: factor out method isKeyBeforeCutoff() 2023-09-12 18:12:56 +02:00
Sean Gilligan
0c7e1aec3b KeyTimeCoinSelector: use Wallet.getConfidence(parent) in isConfirmed() 
Also make `Wallet.getConfidence(parent)` package-private.
 2023-09-12 18:09:06 +02:00
Sean Gilligan
bbe7f088ca KeyTimeCoinSelector: check for parent is non-null in isConfirmed() 2023-09-12 18:05:07 +02:00
Sean Gilligan
110da96911 Wallet: use getAbsoluteFile() when checking if parent directory exists 
This fixes a NPE when using wallet-tool to create a new wallet on a path
without directory, e.g. `wallet-tool create --wallet=test.wallet`.
 2023-09-07 17:44:04 +02:00
Andreas Schildbach
929088cde8 Sha256Hash: add back accessor getReversedBytes() as deprecated 2023-09-07 10:55:34 +02:00
Andreas Schildbach
2cdbc986a8 VersionMessage: add back helper toStringServices() as deprecated 2023-09-07 10:53:06 +02:00
Andreas Schildbach
e2b1c81b60 TransactionOutput: add back a constructor as deprecated 2023-09-07 10:49:58 +02:00
Sean Gilligan
c8bf030824 build.gradle: update EasyMock to 5.2.0 2023-09-02 18:09:47 +02:00
Andreas Schildbach
21549306ad build.gradle: generate protobuf classes into the build directory 2023-09-02 16:31:26 +02:00
Sean Gilligan
4b2a5893ff Peer: improve use of generics for GetDataRequest 
This gets rid of several warnings including two that had been suppressed.
 2023-09-02 00:58:26 +02:00
Sean Gilligan
0033918f82 Transaction: reduce visibility of two methodsn 
This is a minor breaking change to anything relying on the methods that
now have package visibility, but that should be very rare.
 2023-09-01 19:02:07 +02:00
Sean Gilligan
5ff114b7b8 TxConfidenceTable: new method getConfidence(Transaction) 
Use it in `Wallet`.
 2023-09-01 18:59:07 +02:00
Sean Gilligan
dfcaa97b6e Wallet: use getConfidence(Transaction) not Transaction.getConfidence() 2023-09-01 18:55:08 +02:00
Sean Gilligan
d45cccc8d6 CoinSelector: new static method fromPredicate() to create CoinSelector 
Use it in `ForwardingService`.
 2023-09-01 18:38:14 +02:00
Sean Gilligan
111a8b8a37 ListMessage, InventoryMessage, GetDataMessage: make immutable (after deprecations removed) 
Make `ListMessage` and its subclasses "almost" immutable. When the deprecated
`addItem()`, `removeItem()`, etc. methods are removed and the constructors are
changed to create an ummodifiable `List`, they will be immutable.
 2023-09-01 18:24:58 +02:00
Sean Gilligan
9d78d2bd9e Wallet: add getConfidence(tx) method and use it in waitForConfirmations() 
The other `getConfidence()` methods in `Transaction` eventually call the one that
takes a `TxConfidenceTable`, so we call that one directly.

Also prepares for not using `Transaction` to find the `TransactionConfidence`.
 2023-09-01 18:15:52 +02:00
Sean Gilligan
19fcdcdd5b TestFeeLevel, WalletTest: use Wallet.waitForConfirmations() instead of Transaction.getConfidence().getDepthFuture() 2023-08-25 23:42:39 +02:00
Sean Gilligan
c4714f64f8 TransactionConfidence: store overriding txId, rather than transaction reference 
This is a breaking change as `getOverridingTransaction()` has been removed with a replacement
of `getOverridingTxId()`.

Note that ProtoBuf serialization only stores the txId, so this change does not affect
serialization/deserialization.
 2023-08-25 23:39:17 +02:00
Sean Gilligan
14eb9ebf00 TxConfidenceTable: reduce access to fields of WeakConfidenceReference inner class 
* Remove unneeded public modifier from `hash` member and constructor
* Make `hash` member final
 2023-08-25 23:34:06 +02:00