mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-02-22 06:21:47 +01:00
Code Issues Projects Releases Packages Wiki Activity

ForwardingService: improve the implementation of close()

Browse source 
* Don't try to remove listener (access .wallet()) unless kit.isRunning()
* Don't wait for termination, just call kit.stopAsync()
* Add some JavaDoc
This commit is contained in:
Sean Gilligan 2022-07-18 19:34:30 -07:00 • committed by Andreas Schildbach
parent 498d638915
commit fb6add760b
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
examples/src/main/java/org/bitcoinj/examples/ForwardingService.java
View file

@ -133,11 +133,20 @@ public class ForwardingService implements AutoCloseable {
kit.wallet().addCoinsReceivedEventListener(listener); kit.wallet().addCoinsReceivedEventListener(listener);
} }
/**
* Close the service. {@link AutoCloseable} will be triggered if an unhandled exception occurs within
* a <i>try-with-resources</i> block.
* <p>
* Note that {@link WalletAppKit#setAutoStop(boolean)} is set by default and installs a shutdown handler
* via {@link Runtime#addShutdownHook(Thread)} so we do not need to worry about explicitly shutting down
* the {@code WalletAppKit} if the process is terminated.
*/
@Override @Override
public void close() { public void close() {
kit.wallet().removeCoinsReceivedEventListener(listener); if (kit.isRunning()) {
kit.wallet().removeCoinsReceivedEventListener(listener);
}
kit.stopAsync(); kit.stopAsync();
kit.awaitTerminated();
} }
/** /**