mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-15 04:11:51 +01:00
Code Issues Projects Releases Packages Wiki Activity

TransactionInput, TransactionOutPoint: in write(), prefer calling write() over serialize()

Browse source 
The reason is `write()` re-uses the `ByteBuffer`, whereas `serialize()` allocates
an intermediate byte array.
This commit is contained in:
Andreas Schildbach 2025-02-05 13:57:09 +01:00
parent a5aaa8924a
commit f7c7e421fc
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/org/bitcoinj/core/TransactionInput.java
View file

@ -170,7 +170,7 @@ public class TransactionInput {
* @throws BufferOverflowException if the input doesn't fit the remaining buffer * @throws BufferOverflowException if the input doesn't fit the remaining buffer
*/ */
public ByteBuffer write(ByteBuffer buf) throws BufferOverflowException { public ByteBuffer write(ByteBuffer buf) throws BufferOverflowException {
buf.put(outpoint.serialize()); outpoint.write(buf);
Buffers.writeLengthPrefixedBytes(buf, scriptBytes); Buffers.writeLengthPrefixedBytes(buf, scriptBytes);
ByteUtils.writeInt32LE(sequence, buf); ByteUtils.writeInt32LE(sequence, buf);
return buf; return buf;

2
core/src/main/java/org/bitcoinj/core/TransactionOutPoint.java
View file

@ -103,7 +103,7 @@ public class TransactionOutPoint {
* @throws BufferOverflowException if the outpoint doesn't fit the remaining buffer * @throws BufferOverflowException if the outpoint doesn't fit the remaining buffer
*/ */
public ByteBuffer write(ByteBuffer buf) throws BufferOverflowException { public ByteBuffer write(ByteBuffer buf) throws BufferOverflowException {
buf.put(hash.serialize()); hash.write(buf);
ByteUtils.writeInt32LE(index, buf); ByteUtils.writeInt32LE(index, buf);
return buf; return buf;
} }