mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-10 17:26:28 +01:00
Code Issues Projects Releases Packages Wiki Activity

ForwardingService: remove listener properly

Browse source 
The listener wasn't being removed properly, because using a method
reference in both add and remove generated two different objects and
therefore the remove method wasn't finding and removing the listener
that was previously added.

By saving the listener created by the method reference, we can remove
it later.
This commit is contained in:
Sean Gilligan 2024-06-01 13:49:28 -07:00 • committed by Andreas Schildbach
parent 960b254b9d
commit f268eb0cbf
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
examples/src/main/java/org/bitcoinj/examples/ForwardingService.java
View file

@ -51,6 +51,8 @@ public class ForwardingService implements Closeable {
private final BitcoinNetwork network; private final BitcoinNetwork network;
private final Address forwardingAddress; private final Address forwardingAddress;
private volatile WalletAppKit kit; private volatile WalletAppKit kit;
/* We need to save the listener object (created by a method reference) so we can remove it later */
private final WalletCoinsReceivedEventListener coinsReceivedListener = this::coinForwardingListener;
/** /**
* Run the forwarding service as a command line tool * Run the forwarding service as a command line tool
@ -102,7 +104,7 @@ public class ForwardingService implements Closeable {
kit = WalletAppKit.launch(network, new File("."), getPrefix(network), MAX_CONNECTIONS); kit = WalletAppKit.launch(network, new File("."), getPrefix(network), MAX_CONNECTIONS);
// Add a listener that forwards received coins // Add a listener that forwards received coins
kit.wallet().addCoinsReceivedEventListener(this::coinForwardingListener); kit.wallet().addCoinsReceivedEventListener(coinsReceivedListener);
// After we start listening, we can tell the user the receiving address // After we start listening, we can tell the user the receiving address
System.out.printf("Waiting to receive coins on: %s\n", kit.wallet().currentReceiveAddress()); System.out.printf("Waiting to receive coins on: %s\n", kit.wallet().currentReceiveAddress());
@ -120,7 +122,7 @@ public class ForwardingService implements Closeable {
public void close() { public void close() {
if (kit != null) { if (kit != null) {
if (kit.isRunning()) { if (kit.isRunning()) {
kit.wallet().removeCoinsReceivedEventListener(this::coinForwardingListener); kit.wallet().removeCoinsReceivedEventListener(coinsReceivedListener);
} }
kit.close(); kit.close();
} }