From e7545cafe3c086e869c32f1b3d5cf5c251dc67bc Mon Sep 17 00:00:00 2001 From: Sean Gilligan Date: Thu, 27 Feb 2025 10:06:59 -0800 Subject: [PATCH] modular-architecture.md: show SLF4J and JSpecify as dependencies of base This is just a informational change. In the interest of keeping the diagram simple, I have not been showing multiple links to minor direct dependencies. But this change chooses to display SLF4J & JSpecify as direct dependencies of `base`. This makes it more clear that `base`, `core` and `wallet` all will depend on them. The diagram still "lies" a little bit in not showing that they are also direct dependencies, but I think that is an acceptable tradeoff for a diagram that is easier to read. --- designdocs/modular-architecture.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/designdocs/modular-architecture.md b/designdocs/modular-architecture.md index dc4b580e6..3449e1e03 100644 --- a/designdocs/modular-architecture.md +++ b/designdocs/modular-architecture.md @@ -87,8 +87,8 @@ flowchart TD SECPBC --> BC[Bouncy Castle] SECPFFM --> SECPC[libsecp256k1] CORE --> P[ProtoBuf] - CORE .-> S[slf4j] - CORE .-> JS[JSpecify] + BASE .-> S[slf4j] + BASE .-> JS[JSpecify] classDef external fill:#999; class G,S,JS,BC,SECPC,P external; @@ -123,9 +123,9 @@ flowchart TD CO[o.b.core] --> CR[o.b.crypto] end CORE --> BASE - CORE .-> S[slf4j] - CORE .-> JS[JSpecify] CORE --> SECP + BASE .-> S[slf4j] + BASE .-> JS[JSpecify] SECP[secp-api] .-> SECPFFM[secp-ffm] SECP .-> SECPBOUNCY[secp-bouncy] SECPBOUNCY .-> BC[Bouncy Castle]