From ce32f2a5ba9fb033fc81daacda0e4701cff0b774 Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Sun, 17 Jan 2016 18:06:30 +0100 Subject: [PATCH] WalletTest: Extract empty sig constant. --- .../src/test/java/org/bitcoinj/wallet/WalletTest.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java index f7780878a..fa1eb946a 100644 --- a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java +++ b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java @@ -3087,6 +3087,8 @@ public class WalletTest extends TestWithWallet { assertEquals(200, tx.getInputs().size()); } + private static final byte[] EMPTY_SIG = {}; + @Test public void completeTxPartiallySignedWithDummySigs() throws Exception { byte[] dummySig = TransactionSignature.dummy().encodeToBitcoin(); @@ -3095,8 +3097,7 @@ public class WalletTest extends TestWithWallet { @Test public void completeTxPartiallySignedWithEmptySig() throws Exception { - byte[] emptySig = {}; - completeTxPartiallySigned(Wallet.MissingSigsMode.USE_OP_ZERO, emptySig); + completeTxPartiallySigned(Wallet.MissingSigsMode.USE_OP_ZERO, EMPTY_SIG); } @Test (expected = ECKey.MissingPrivateKeyException.class) @@ -3119,14 +3120,12 @@ public class WalletTest extends TestWithWallet { @Test public void completeTxPartiallySignedMarriedWithEmptySig() throws Exception { - byte[] emptySig = {}; - completeTxPartiallySignedMarried(Wallet.MissingSigsMode.USE_OP_ZERO, emptySig); + completeTxPartiallySignedMarried(Wallet.MissingSigsMode.USE_OP_ZERO, EMPTY_SIG); } @Test (expected = TransactionSigner.MissingSignatureException.class) public void completeTxPartiallySignedMarriedThrows() throws Exception { - byte[] emptySig = {}; - completeTxPartiallySignedMarried(Wallet.MissingSigsMode.THROW, emptySig); + completeTxPartiallySignedMarried(Wallet.MissingSigsMode.THROW, EMPTY_SIG); } @Test (expected = TransactionSigner.MissingSignatureException.class)