mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-02-23 14:40:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

KeyChainGroupTest: reduce false positive rate for the bloom filters

Browse source 
This will hopefully reduce spurious test failures.
This commit is contained in:
Andreas Schildbach 2023-03-25 13:29:20 +01:00
parent 3bbbf40fa4
commit b585f9f08e
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/src/test/java/org/bitcoinj/wallet/KeyChainGroupTest.java
View file

@ -64,6 +64,7 @@ public class KeyChainGroupTest {
private static final byte[] ENTROPY = Sha256Hash.hash("don't use a string seed like this in real life".getBytes()); private static final byte[] ENTROPY = Sha256Hash.hash("don't use a string seed like this in real life".getBytes());
private static final KeyCrypterScrypt KEY_CRYPTER = new KeyCrypterScrypt(2); private static final KeyCrypterScrypt KEY_CRYPTER = new KeyCrypterScrypt(2);
private static final AesKey AES_KEY = KEY_CRYPTER.deriveKey("password"); private static final AesKey AES_KEY = KEY_CRYPTER.deriveKey("password");
private static final double LOW_FALSE_POSITIVE_RATE = 0.00001;
private KeyChainGroup group; private KeyChainGroup group;
private DeterministicKey watchingAccountKey; private DeterministicKey watchingAccountKey;
@ -344,7 +345,7 @@ public class KeyChainGroupTest {
public void bloom() { public void bloom() {
ECKey key1 = group.freshKey(KeyChain.KeyPurpose.RECEIVE_FUNDS); ECKey key1 = group.freshKey(KeyChain.KeyPurpose.RECEIVE_FUNDS);
ECKey key2 = new ECKey(); ECKey key2 = new ECKey();
BloomFilter filter = group.getBloomFilter(group.getBloomFilterElementCount(), 0.001, new Random().nextInt()); BloomFilter filter = group.getBloomFilter(group.getBloomFilterElementCount(), LOW_FALSE_POSITIVE_RATE, new Random().nextInt());
assertTrue(filter.contains(key1.getPubKeyHash())); assertTrue(filter.contains(key1.getPubKeyHash()));
assertTrue(filter.contains(key1.getPubKey())); assertTrue(filter.contains(key1.getPubKey()));
assertFalse(filter.contains(key2.getPubKey())); assertFalse(filter.contains(key2.getPubKey()));
@ -356,7 +357,7 @@ public class KeyChainGroupTest {
// We ran ahead of the lookahead buffer. // We ran ahead of the lookahead buffer.
assertFalse(filter.contains(group.freshKey(KeyChain.KeyPurpose.RECEIVE_FUNDS).getPubKey())); assertFalse(filter.contains(group.freshKey(KeyChain.KeyPurpose.RECEIVE_FUNDS).getPubKey()));
group.importKeys(key2); group.importKeys(key2);
filter = group.getBloomFilter(group.getBloomFilterElementCount(), 0.001, new Random().nextInt()); filter = group.getBloomFilter(group.getBloomFilterElementCount(), LOW_FALSE_POSITIVE_RATE, new Random().nextInt());
assertTrue(filter.contains(key1.getPubKeyHash())); assertTrue(filter.contains(key1.getPubKeyHash()));
assertTrue(filter.contains(key1.getPubKey())); assertTrue(filter.contains(key1.getPubKey()));
assertTrue(filter.contains(key2.getPubKey())); assertTrue(filter.contains(key2.getPubKey()));
@ -387,7 +388,7 @@ public class KeyChainGroupTest {
assertEquals(expected, group.getBloomFilterElementCount()); assertEquals(expected, group.getBloomFilterElementCount());
Address address1 = group.freshAddress(KeyChain.KeyPurpose.RECEIVE_FUNDS); Address address1 = group.freshAddress(KeyChain.KeyPurpose.RECEIVE_FUNDS);
assertEquals(expected, group.getBloomFilterElementCount()); assertEquals(expected, group.getBloomFilterElementCount());
BloomFilter filter = group.getBloomFilter(expected + 2, 0.001, new Random().nextInt()); BloomFilter filter = group.getBloomFilter(expected + 2, LOW_FALSE_POSITIVE_RATE, new Random().nextInt());
assertTrue(filter.contains(address1.getHash())); assertTrue(filter.contains(address1.getHash()));
Address address2 = group.freshAddress(KeyChain.KeyPurpose.CHANGE); Address address2 = group.freshAddress(KeyChain.KeyPurpose.CHANGE);