From aa33c0e8431a031e2c02e009474433dd743665ad Mon Sep 17 00:00:00 2001 From: Ross Nicoll Date: Sat, 13 Feb 2016 15:50:27 +0000 Subject: [PATCH] PeerGroupTest: Add listeners before calling start() PeerGroupTest.listener() currently starts the PeerGroup before adding listeners to it. While the events being listened for are not triggered until later in the test, it is good practice to add listeners before calling start() --- core/src/test/java/org/bitcoinj/core/PeerGroupTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/test/java/org/bitcoinj/core/PeerGroupTest.java b/core/src/test/java/org/bitcoinj/core/PeerGroupTest.java index bc07b0ac1..53036c1a8 100644 --- a/core/src/test/java/org/bitcoinj/core/PeerGroupTest.java +++ b/core/src/test/java/org/bitcoinj/core/PeerGroupTest.java @@ -108,9 +108,9 @@ public class PeerGroupTest extends TestWithPeerGroup { @Test public void listener() throws Exception { - peerGroup.start(); peerGroup.addConnectionEventListener(listener); peerGroup.addPreMessageReceivedEventListener(preMessageReceivedListener); + peerGroup.start(); // Create a couple of peers. InboundMessageQueuer p1 = connectPeer(1);