From a3f82d6baee1dfa88e9ce3d6cfb455ee3fbb2406 Mon Sep 17 00:00:00 2001 From: Andreas Schildbach Date: Fri, 31 Mar 2023 10:34:56 +0200 Subject: [PATCH] TransactionInput: remove helper `duplicateDetached()` It is only used from a test, and that test works just as well by just copying the reference. --- core/src/main/java/org/bitcoinj/core/TransactionInput.java | 5 ----- core/src/test/java/org/bitcoinj/core/TransactionTest.java | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/core/src/main/java/org/bitcoinj/core/TransactionInput.java b/core/src/main/java/org/bitcoinj/core/TransactionInput.java index e9a7c9be2..606776297 100644 --- a/core/src/main/java/org/bitcoinj/core/TransactionInput.java +++ b/core/src/main/java/org/bitcoinj/core/TransactionInput.java @@ -496,11 +496,6 @@ public class TransactionInput extends Message { return getOutpoint().fromTx; } - /** Returns a copy of the input detached from its containing transaction, if need be. */ - public TransactionInput duplicateDetached() { - return new TransactionInput(null, ByteBuffer.wrap(bitcoinSerialize())); - } - /** *

Returns either RuleViolation.NONE if the input is standard, or which rule makes it non-standard if so. * The "IsStandard" rules control whether the default Bitcoin Core client blocks relay of a tx / refuses to mine it, diff --git a/core/src/test/java/org/bitcoinj/core/TransactionTest.java b/core/src/test/java/org/bitcoinj/core/TransactionTest.java index ab5f79c77..8ddea6217 100644 --- a/core/src/test/java/org/bitcoinj/core/TransactionTest.java +++ b/core/src/test/java/org/bitcoinj/core/TransactionTest.java @@ -107,7 +107,7 @@ public class TransactionTest { public void duplicateOutPoint() { TransactionInput input = tx.getInput(0); input.setScriptBytes(new byte[1]); - tx.addInput(input.duplicateDetached()); + tx.addInput(input); tx.verify(); }