TransactionTest: migrate remaining assertTrue()/assertFalse() from assertEquals()

This commit is contained in:
Andreas Schildbach 2023-04-01 10:46:37 +02:00
parent efdef581ee
commit a2abdfa136

View file

@ -187,13 +187,13 @@ public class TransactionTest {
Transaction tx = FakeTxBuilder.createFakeCoinbaseTx(TESTNET); Transaction tx = FakeTxBuilder.createFakeCoinbaseTx(TESTNET);
tx.getConfidence().setConfidenceType(ConfidenceType.UNKNOWN); tx.getConfidence().setConfidenceType(ConfidenceType.UNKNOWN);
assertEquals(tx.isMature(), false); assertFalse(tx.isMature());
tx.getConfidence().setConfidenceType(ConfidenceType.PENDING); tx.getConfidence().setConfidenceType(ConfidenceType.PENDING);
assertEquals(tx.isMature(), false); assertFalse(tx.isMature());
tx.getConfidence().setConfidenceType(ConfidenceType.DEAD); tx.getConfidence().setConfidenceType(ConfidenceType.DEAD);
assertEquals(tx.isMature(), false); assertFalse(tx.isMature());
} }
@Test @Test
@ -489,8 +489,8 @@ public class TransactionTest {
String str = tx.toString(mockBlockChain, BitcoinNetwork.TESTNET); String str = tx.toString(mockBlockChain, BitcoinNetwork.TESTNET);
assertEquals(str.contains("block " + TEST_LOCK_TIME), true); assertTrue(str.contains("block " + TEST_LOCK_TIME));
assertEquals(str.contains("estimated to be reached at"), true); assertTrue(str.contains("estimated to be reached at"));
} }
@Test @Test
@ -504,13 +504,13 @@ public class TransactionTest {
}; };
tx.addInput(ti); tx.addInput(ti);
assertEquals(tx.toString().contains("[exception: "), true); assertTrue(tx.toString().contains("[exception: "));
} }
@Test @Test
public void testToStringWhenThereAreZeroInputs() { public void testToStringWhenThereAreZeroInputs() {
Transaction tx = new Transaction(TESTNET); Transaction tx = new Transaction(TESTNET);
assertEquals(tx.toString().contains("No inputs!"), true); assertTrue(tx.toString().contains("No inputs!"));
} }
@Test @Test
@ -531,14 +531,14 @@ public class TransactionTest {
Iterator<Transaction> iterator = set.iterator(); Iterator<Transaction> iterator = set.iterator();
assertEquals(tx1.equals(tx2), false); assertFalse(tx1.equals(tx2));
assertEquals(tx1.equals(tx3), false); assertFalse(tx1.equals(tx3));
assertEquals(tx1.equals(tx1), true); assertTrue(tx1.equals(tx1));
assertEquals(iterator.next().equals(tx3), true); assertTrue(iterator.next().equals(tx3));
assertEquals(iterator.next().equals(tx2), true); assertTrue(iterator.next().equals(tx2));
assertEquals(iterator.next().equals(tx1), true); assertTrue(iterator.next().equals(tx1));
assertEquals(iterator.hasNext(), false); assertFalse(iterator.hasNext());
} }
@Test(expected = ScriptException.class) @Test(expected = ScriptException.class)