mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2024-11-20 10:12:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

TransactionBroadcast: extract method broadcastOne(Peer)

Browse Source 
* Move code to broadcast to one peer into broadcastOne(Peer) method
* Stop swallowing (but logging) exception thrown by peer.sendMessage(tx)
This commit is contained in:
Sean Gilligan 2022-07-30 21:51:33 -07:00 committed by Andreas Schildbach
parent e078421edd
commit 81fd758800
1 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java
View File

@ -187,24 +187,8 @@ public class TransactionBroadcast {
CompletableFuture[] sentFutures = new CompletableFuture[broadcastPeers.size()];
int i = 0;
for (final Peer peer : broadcastPeers) {
try {
CompletableFuture<Void> future = peer.sendMessage(tx);
if (dropPeersAfterBroadcast) {
// We drop the peer shortly after the transaction has been sent, because this peer will not
// send us back useful broadcast confirmations.
future.thenRunAsync(() -> {
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
peer.close();
}, Threading.THREAD_POOL);
}
sentFutures[i] = future;
i++;
// We don't record the peer as having seen the tx in the memory pool because we want to track only
// how many peers announced to us.
} catch (Exception e) {
// TODO: Put this exception into our returned future
log.error("Caught exception sending to {}", peer, e);
}
sentFutures[i] = broadcastOne(peer);
i++;
}
// Complete successfully if ALL peer.sendMessage complete successfully, fail otherwise
return CompletableFuture.allOf(sentFutures);
@ -222,6 +206,26 @@ public class TransactionBroadcast {
return ListenableCompletableFuture.of(seenFuture);
}
private CompletableFuture<Void> broadcastOne(Peer peer) {
try {
CompletableFuture<Void> future = peer.sendMessage(tx);
if (dropPeersAfterBroadcast) {
// We drop the peer shortly after the transaction has been sent, because this peer will not
// send us back useful broadcast confirmations.
future.thenRunAsync(() -> {
Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
peer.close();
}, Threading.THREAD_POOL);
}
// We don't record the peer as having seen the tx in the memory pool because we want to track only
// how many peers announced to us.
return future;
} catch (Exception e) {
log.error("Caught exception sending to {}", peer, e);
return ListenableCompletableFuture.failedFuture(e);
}
}
/**
* Randomly choose a subset of connected peers to broadcast to
* @param connectedPeers connected peers to chose from