mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-10 09:20:04 +01:00
Code Issues Projects Releases Packages Wiki Activity

Transaction: remove the input and output re-reading

Browse source 
We needed this to correctly determine the message length, but that
requirement is gone.
This commit is contained in:
Andreas Schildbach 2023-04-13 11:11:03 +02:00
parent 1fef4e2cdb
commit 7d31021663
1 changed files with 2 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/src/main/java/org/bitcoinj/core/Transaction.java
View file

@ -642,13 +642,7 @@ public class Transaction extends BaseMessage {
int numInputs = numInputsVarInt.intValue();
inputs = new ArrayList<>(Math.min((int) numInputs, Utils.MAX_INITIAL_ARRAY_LENGTH));
for (long i = 0; i < numInputs; i++) {
TransactionInput input = TransactionInput.read(payload.slice(), this);
inputs.add(input);
// intentionally read again, due to the slice above
Buffers.skipBytes(payload, TransactionOutPoint.BYTES);
VarInt scriptLenVarInt = VarInt.read(payload);
int scriptLen = scriptLenVarInt.intValue();
Buffers.skipBytes(payload, scriptLen + 4);
inputs.add(TransactionInput.read(payload, this));
}
}
@ -658,13 +652,7 @@ public class Transaction extends BaseMessage {
int numOutputs = numOutputsVarInt.intValue();
outputs = new ArrayList<>(Math.min((int) numOutputs, Utils.MAX_INITIAL_ARRAY_LENGTH));
for (long i = 0; i < numOutputs; i++) {
TransactionOutput output = TransactionOutput.read(payload.slice(), this);
outputs.add(output);
// intentionally read again, due to the slice above
Buffers.skipBytes(payload, 8); // value
VarInt scriptLenVarInt = VarInt.read(payload);
int scriptLen = scriptLenVarInt.intValue();
Buffers.skipBytes(payload, scriptLen);
outputs.add(TransactionOutput.read(payload, this));
}
}