mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-01-18 21:32:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Signers: skip signing if input is fully signed already

Browse Source
This commit is contained in:
Kosta Korenkov 2014-09-11 19:18:09 +08:00
parent cf5089697b
commit 77f414fc62
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/main/java/com/google/bitcoin/signers/CustomTransactionSigner.java
View File

@ -60,8 +60,20 @@ public abstract class CustomTransactionSigner extends StatelessTransactionSigner
log.warn("CustomTransactionSigner works only with P2SH transactions");
return false;
}
Script inputScript = txIn.getScriptSig();
checkNotNull(inputScript);
Script inputScript = checkNotNull(txIn.getScriptSig());
try {
// We assume if its already signed, its hopefully got a SIGHASH type that will not invalidate when
// we sign missing pieces (to check this would require either assuming any signatures are signing
// standard output types or a way to get processed signatures out of script execution)
txIn.getScriptSig().correctlySpends(tx, i, txIn.getConnectedOutput().getScriptPubKey(), true);
log.warn("Input {} already correctly spends output, assuming SIGHASH type used will be safe and skipping signing.", i);
continue;
} catch (ScriptException e) {
// Expected.
}
RedeemData redeemData = txIn.getConnectedRedeemData(keyBag);
if (redeemData == null) {
log.warn("No redeem data found for input {}", i);