mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-10 09:20:04 +01:00
Code Issues Projects Releases Packages Wiki Activity

Transaction: use Stream.reduce() in getInputSum()

Browse source
This commit is contained in:
Sean Gilligan 2023-05-09 13:48:39 -07:00 • committed by Andreas Schildbach
parent 36129e53ef
commit 74b7b11681
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
core/src/main/java/org/bitcoinj/core/Transaction.java
View file

@ -382,20 +382,19 @@ public class Transaction extends BaseMessage {
return IntMath.divide(getWeight(), 4, RoundingMode.CEILING); // round up
}
/**
* Gets the sum of the inputs, regardless of who owns them.
* Gets the sum of all transaction inputs, regardless of who owns them.
* <p>
* <b>Warning:</b> Inputs with {@code null} {@link TransactionInput#getValue()} are silently skipped. Before completing
* or signing a transaction you should verify that there are no inputs with {@code null} values.
* @return The sum of all inputs with non-null values.
*/
public Coin getInputSum() {
Coin inputTotal = Coin.ZERO;
for (TransactionInput input: inputs) {
Coin inputValue = input.getValue();
if (inputValue != null) {
inputTotal = inputTotal.add(inputValue);
}
}
return inputTotal;
return inputs.stream()
.map(TransactionInput::getValue)
.filter(Objects::nonNull)
.reduce(Coin.ZERO, Coin::add);
}
/**