mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-01-19 05:33:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

ListMessage: fix number of inventory items read as long

Browse Source
This commit is contained in:
Andreas Schildbach 2023-04-13 12:03:18 +02:00
parent 838d14d027
commit 6b7fe58955
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/main/java/org/bitcoinj/core/ListMessage.java
View File

@ -40,7 +40,7 @@ public abstract class ListMessage extends Message {
// For some reason the compiler complains if this is inside InventoryItem
protected List<InventoryItem> items;
public static final long MAX_INVENTORY_ITEMS = 50000;
public static final int MAX_INVENTORY_ITEMS = 50000;
public ListMessage(ByteBuffer payload) throws ProtocolException {
super(payload);
@ -65,12 +65,12 @@ public abstract class ListMessage extends Message {
@Override
protected void parse(ByteBuffer payload) throws BufferUnderflowException, ProtocolException {
long arrayLen = VarInt.read(payload).longValue();
int arrayLen = VarInt.read(payload).intValue();
if (arrayLen > MAX_INVENTORY_ITEMS)
throw new ProtocolException("Too many items in INV message: " + arrayLen);
// An inv is vector<CInv> where CInv is int+hash. The int is either 1 or 2 for tx or block.
items = new ArrayList<>((int) arrayLen);
items = new ArrayList<>(arrayLen);
for (int i = 0; i < arrayLen; i++) {
if (payload.remaining() < InventoryItem.MESSAGE_LENGTH) {
throw new ProtocolException("Ran off the end of the INV");