mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-03-10 17:26:28 +01:00
Code Issues Projects Releases Packages Wiki Activity

Transaction.getFee(): Do not determine fee on incomplete transactions.

Browse source
This commit is contained in:
Andreas Schildbach 2017-06-02 15:32:42 +02:00
parent e62275d41b
commit 6841fceabc
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/org/bitcoinj/core/Transaction.java
View file

@ -415,6 +415,8 @@ public class Transaction extends ChildMessage {
*/
public Coin getFee() {
Coin fee = Coin.ZERO;
if (inputs.isEmpty() || outputs.isEmpty()) // Incomplete transaction
return null;
for (TransactionInput input : inputs) {
if (input.getValue() == null)
return null;

2
core/src/test/java/org/bitcoinj/wallet/WalletTest.java
View file

@ -2865,8 +2865,8 @@ public class WalletTest extends TestWithWallet {
wallet.receiveFromBlock(tx, block, AbstractBlockChain.NewBlockType.BEST_CHAIN, 0);
try {
request = SendRequest.emptyWallet(OTHER_ADDRESS);
assertEquals(ZERO, request.tx.getFee());
wallet.completeTx(request);
assertEquals(ZERO, request.tx.getFee());
fail();
} catch (Wallet.CouldNotAdjustDownwards e) {}
}