mirrors/bitcoinj
1
0
Fork 0
mirror of https://github.com/bitcoinj/bitcoinj.git synced 2025-02-22 22:25:41 +01:00
Code Issues Projects Releases Packages Wiki Activity

DnsDiscovery: remove Linux gethostbyname bug workaround from 2015

Browse source
This commit is contained in:
Sean Gilligan 2023-08-14 16:16:49 -07:00 • committed by Andreas Schildbach
parent 07ca73cce7
commit 624df43ada
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/src/main/java/org/bitcoinj/net/discovery/DnsDiscovery.java
View file

@ -18,11 +18,9 @@
package org.bitcoinj.net.discovery; package org.bitcoinj.net.discovery;
import org.bitcoinj.base.Network; import org.bitcoinj.base.Network;
import org.bitcoinj.base.internal.PlatformUtils;
import org.bitcoinj.core.NetworkParameters; import org.bitcoinj.core.NetworkParameters;
import org.bitcoinj.core.Services; import org.bitcoinj.core.Services;
import org.bitcoinj.core.VersionMessage; import org.bitcoinj.core.VersionMessage;
import org.bitcoinj.utils.ContextPropagatingThreadFactory;
import org.bitcoinj.utils.DaemonThreadFactory; import org.bitcoinj.utils.DaemonThreadFactory;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -96,12 +94,7 @@ public class DnsDiscovery extends MultiplexingDiscovery {
@Override @Override
protected ExecutorService createExecutor() { protected ExecutorService createExecutor() {
// Attempted workaround for reported bugs on Linux in which gethostbyname does not appear to be properly return Executors.newFixedThreadPool(seeds.size(), new DaemonThreadFactory("DNS seed lookups"));
// thread safe and can cause segfaults on some libc versions.
if (PlatformUtils.isLinux())
return Executors.newSingleThreadExecutor(new ContextPropagatingThreadFactory("DNS seed lookups"));
else
return Executors.newFixedThreadPool(seeds.size(), new DaemonThreadFactory("DNS seed lookups"));
} }
/** Implements discovery from a single DNS host. */ /** Implements discovery from a single DNS host. */